Build libjpeg with -DBUILD_SHARED_LIBS=OFF in test code. NFC. - #8363
Merged
Conversation
This fixes the breakage with latest llvm upstream that honors `-fPIC`.
kripken
reviewed
Mar 29, 2019
kripken
left a comment
kripken
left a comment
Member
There was a problem hiding this comment.
This seems fine as a workaround, but I think we should focus on getting it to work as opposed to getting the test to pass, since this is common in real-world code.
Collaborator
Author
|
I think the real fix is #8362, at least until we really do support building and using shared libraries. |
VirtualTim
pushed a commit
to VirtualTim/emscripten
that referenced
this pull request
May 21, 2019
…pten-core#8363) This fixes the breakage with latest llvm upstream that honors `-fPIC`.
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
VirtualTim
added a commit
to VirtualTim/emscripten
that referenced
this pull request
May 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the breakage with latest llvm upstream that honors
-fPIC.This would also be fixed by the more intrusive change in #8362.