React Native needs to be treated like a node environment

[brandonlehmann]

We consistently see issues whereby React Native is not detected properly and thus generated JS does not load. React Native needs to be treated as if it is Node for modules to initialize correctly.

[kripken]

Thanks @brandonlehmann!

I think this can use the ENVIRONMENT_HAS_NODE feature from line 76 a little above? @ericmandel added that and may have more thoughts.

Also @brandonlehmann please add yourself to AUTHORS.

[ericmandel]

@brandonlehmann @kripken I'm not very familiar with React Native, but if it is meant to be treated as a full-up Node environment, then ENVIRONMENT_IS_NODE is indeed wanted, not ENVIRONMENT_HAS_NODE, which is used, for example, by Web environments like Electron.js that can have Node integrated into it.

But ... while resetting ENVIRONMENT_IS_NODE, you might need to set ENVIRONMENT_HAS_NODE as well, since the former is used explicitly in some checks ... unless React Native has already passed the ENVIRONMENT_HAS_NODE check at line 76?

[jkbbwr]

Side note, unless React Native has changed the bundler they are using (Metro last time I checked) It does static analysis and freaks out if modules like fs are required even if that is dead code.

[sbc100]

The deletion of the incoming branch triggered the automatic closing of this branch. My apologies. This was an unexpected side effect.

Re-opening and re-targeting to master.

[stale]

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.