Add libunwind (LLVM 8.0.1) - #9442
Merged
Merged
Conversation
This adds vanilla libunwind, without any modifications. Any modifications will come after as separate patches. In fact we are not gonna use most of cpp implementations here - each cpp file is an implementation for a single platform for the same API. (And I'm planning to add one for wasm in later patches.) But I think making our code coexist with the upstream code will make it easier to stay up-to-date and later possibly merge in.
sbc100
approved these changes
Sep 17, 2019
aheejin
added a commit
to aheejin/emscripten
that referenced
this pull request
Sep 19, 2019
This was missing in emscripten-core#9442.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
This adds vanilla libunwind, without any modifications. Any modifications will come after as separate patches. In fact we are not gonna use most of cpp implementations here - each cpp file is an implementation for a single platform for the same API. (And I'm planning to add one for wasm in later patches.) But I think making our code coexist with the upstream code will make it easier to stay up-to-date and later possibly merge in.
belraquib
pushed a commit
to belraquib/emscripten
that referenced
this pull request
Dec 23, 2020
This was missing in emscripten-core#9442.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds vanilla libunwind, without any modifications. Any
modifications will come after as separate patches.
In fact we are not gonna use most of cpp implementations here - each cpp
file is an implementation for a single platform for the same API. (And
I'm planning to add one for wasm in later patches.) But I think making
our code coexist with the upstream code will make it easier to stay
up-to-date and later possibly merge in.