Fixed a possible access violation in WebSession#193
Merged
emweb merged 1 commit intoemweb:masterfrom Jun 23, 2022
Merged
Conversation
skoehler47
changed the title
emweb
suggested changes
Jun 23, 2022
Collaborator
emweb
left a comment
emweb
left a comment
There was a problem hiding this comment.
Thanks for your contribution. I have a few small remarks. If you can address them that would be great 🙂
Roel
the 'ApplicationCreator function' returns a nullptr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a fix for a segmentation fault during application creation, if the application create function used for an entry point returns a nullptr - as described in Issue 10483.