Skip to content

WRN-18582: Migrate to webpack5 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hong6316 merged 10 commits into from
Mar 23, 2022
Merged

WRN-18582: Migrate to webpack5 #264

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
49cf168
WRN-18582: webpack5 initial commit
MikyungKim Mar 11, 2022
1a1a56c
WRN-18582: Fixed serve issue
MikyungKim Mar 14, 2022
09ef85a
WRN-18582: Added webpack cache config
MikyungKim Mar 16, 2022
08121e0
applied more changes
MikyungKim Mar 18, 2022
b23d209
Added changelog
MikyungKim Mar 21, 2022
9c324d4
fix
MikyungKim Mar 21, 2022
0feaa9a
update `listen` to `startCallback` from webpack dev server
MikyungKim Mar 22, 2022
a05cdf6
fix filename..ext issue
MikyungKim Mar 22, 2022
ea66262
WRN-16762: Added support for tailwindcss and update dependencies (#263)
hong6316 Mar 22, 2022
e000317
update changelog and package.json
MikyungKim Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
applied more changes 
Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)
  • Loading branch information
@MikyungKim
MikyungKim committed Mar 18, 2022
commit 08121e067e3abf24d681bb967b07c7b8a9fa4230
18 changes: 11 additions & 7 deletions commands/pack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,13 +101,17 @@ function details(err, stats, output) {
process.env.CI.toLowerCase() !== 'false' &&
messages.warnings.length
) {
console.log(
chalk.yellow(
'Treating warnings as errors because process.env.CI = true. ' +
'Most CI servers set it automatically.\n'
)
);
return new Error(messages.warnings.join('\n\n'));
// Ignore sourcemap warnings in CI builds. See #8227 for more info.
const filteredWarnings = messages.warnings.filter(w => !/Failed to parse source map/.test(w));
if (filteredWarnings.length) {
console.log(
chalk.yellow(
'\nTreating warnings as errors because process.env.CI = true. \n' +
'Most CI servers set it automatically.\n'
)
);
return new Error(filteredWarnings.join('\n\n'));
}
} else {
copyPublicFolder(output);
if (messages.warnings.length) {
Expand Down
9 changes: 7 additions & 2 deletions commands/serve.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,9 @@ function devServerConfig(host, protocol, publicPath, proxy, allowedHost) {
host,
// Allow cross-origin HTTP requests
headers: {
'Access-Control-Allow-Origin': '*'
'Access-Control-Allow-Origin': '*',
'Access-Control-Allow-Methods': '*',
'Access-Control-Allow-Headers': '*'
},
static: {
// By default WebpackDevServer serves physical files from current directory
Expand Down Expand Up @@ -166,7 +168,10 @@ function devServerConfig(host, protocol, publicPath, proxy, allowedHost) {
pathname: process.env.WDS_SOCKET_PATH,
port: process.env.WDS_SOCKET_PORT
},
overlay: true
overlay: {
errors: true,
warnings: false
}
},
devMiddleware: {
// It is important to tell WebpackDevServer to use the same "publicPath" path as
Expand Down
33 changes: 23 additions & 10 deletions config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ module.exports = function (env, ilibAdditionalResourcesPath) {
options: Object.assign(
{importLoaders: preProcessor ? 2 : 1, sourceMap: shouldUseSourceMap},
cssLoaderOptions,
cssLoaderOptions.modules && {modules: {getLocalIdent}},
{
url: {
filter: url => {
Expand Down Expand Up @@ -265,6 +264,12 @@ module.exports = function (env, ilibAdditionalResourcesPath) {
// @remove-on-eject-end
module: {
rules: [
shouldUseSourceMap && {
enforce: 'pre',
exclude: /@babel(?:\/|\\{1,2})runtime/,
test: /\.(js|mjs|jsx|ts|tsx|css)$/,
loader: require.resolve('source-map-loader')
},
{
// "oneOf" will traverse all following loaders until one will
// match the requirements. When no loader matches it will fall
Expand Down Expand Up @@ -293,17 +298,21 @@ module.exports = function (env, ilibAdditionalResourcesPath) {
{
test: /\.module\.css$/,
use: getStyleLoaders({
//mode: 'local',
modules: true
modules: {
getLocalIdent,
mode: 'local'
}
})
},
{
test: /\.css$/,
// The `forceCSSModules` Enact build option can be set true to universally apply
// modular CSS support.
use: getStyleLoaders({
//mode: 'icss',
modules: app.forceCSSModules
modules: {
...(app.forceCSSModules ? {getLocalIdent} : {}),
mode: 'icss'
}
}),
// Don't consider CSS imports dead code even if the
// containing package claims to have no side effects.
Expand All @@ -314,15 +323,19 @@ module.exports = function (env, ilibAdditionalResourcesPath) {
{
test: /\.module\.less$/,
use: getLessStyleLoaders({
//mode: 'local',
modules: true
modules: {
getLocalIdent,
mode: 'local'
}
})
},
{
test: /\.less$/,
use: getLessStyleLoaders({
//mode: 'icss',
modules: app.forceCSSModules
modules: {
...(app.forceCSSModules ? {getLocalIdent} : {}),
mode: 'icss'
}
}),
sideEffects: true
},
Expand All @@ -343,7 +356,7 @@ module.exports = function (env, ilibAdditionalResourcesPath) {
// Make sure to add the new loader(s) before the "file" loader.
]
}
]
].filter(Boolean)
},
// Specific webpack-dev-server options.
devServer: {
Expand Down
Loading