Skip to content

Add a check for 'required' before deletion #6920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
haiyangdeperci wants to merge 2 commits into from
Closed

Add a check for 'required' before deletion #6920

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30c91a6
Add a check for 'required' before deletion
haiyangdeperci Sep 9, 2019
89383fc
Update rest_framework/schemas/openapi.py
haiyangdeperci Sep 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rest_framework/schemas/openapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ def _get_request_body(self, path, method):

content = self._map_serializer(serializer)
# No required fields for PATCH
if method == 'PATCH':
if method == 'PATCH' and 'required' in content:
del content['required']
Copy link
Copy Markdown
Contributor

@guimunarolo guimunarolo Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if method == 'PATCH':
    content.pop('required', None)

# No read_only fields for request.
for name, schema in content['properties'].copy().items():
Expand Down