Skip to content

MANIFEST.in: Adding tests to sdist tarball.#7145

Merged
lovelydinosaur merged 1 commit into
encode:masterfrom
dvzrv:issue/7141
Jan 15, 2020
Merged

MANIFEST.in: Adding tests to sdist tarball.#7145
lovelydinosaur merged 1 commit into
encode:masterfrom
dvzrv:issue/7141

Conversation

@dvzrv

@dvzrv dvzrv commented Jan 15, 2020

Copy link
Copy Markdown
Contributor

Description

Adds tests to the sdist tarball, so they will also be available in the source tarball on pypi.org.
Fixes #7141.

@lovelydinosaur

Copy link
Copy Markdown
Contributor

Okay I'm actually less reticent than on the first pass.
I'd checked out a couple of other prominent packages, and thought they weren't including the tests, but turned out they do. (I was just looking in the wrong place.)

So, probably a yes, barring any other maintainers taking a view on this?

@rpkilby

rpkilby commented Jan 15, 2020

Copy link
Copy Markdown
Contributor

I'd checked out a couple of other prominent packages, and thought they weren't including the tests

It's worth noting that the tests aren't installed into site-packages, just included with the distribution. This also doesn't negatively affect wheels.

@lovelydinosaur
lovelydinosaur merged commit 7bd7301 into encode:master Jan 15, 2020
pchiquet pushed a commit to pchiquet/django-rest-framework that referenced this pull request Nov 17, 2020
sigvef pushed a commit to sigvef/django-rest-framework that referenced this pull request Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests not in pypi sdist

3 participants