Fix synchronous TLS-in-TLS streams#840
Merged
karpetrosyan merged 2 commits intoencode:masterfrom Nov 2, 2023
Merged
Conversation
lovelydinosaur
approved these changes
Nov 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #841
I'm not sure how we missed that, but it appears we have an if statement that prevents
TLS-in-TLSstreams for synchronous backends.@tomchristie included a basic example of how to test this feature in sync and async code in the pull request that adds HTTPS proxy support.
This pull request simply corrects
TLS-in-TLSsync by removing unnecessary if. To test locally, follow the steps outlined in the PR that adds HTTPS proxy support.