Drop private import of 'encode_request' in test_multipart#2525
Merged
lovelydinosaur merged 3 commits intomasterfrom Jan 10, 2023
Merged
Drop private import of 'encode_request' in test_multipart#2525lovelydinosaur merged 3 commits intomasterfrom
lovelydinosaur merged 3 commits intomasterfrom
Conversation
michaeloliverx
approved these changes
Jan 10, 2023
Contributor
michaeloliverx
left a comment
michaeloliverx
left a comment
There was a problem hiding this comment.
Makes sense to dog food the public API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2492
This is just a test refactoring.
Use
httpx.Request(...)to handle the multipart tests, rather than importing theencode_requestfunction, which is a private implementation detail. Having tests against our public API makes more sense than digging into private imports.