Skip to content

Change timeout values to be ints #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vpetro wants to merge 1 commit into from
Closed

Change timeout values to be ints #3421

vpetro wants to merge 1 commit into from

Conversation

@vpetro
Copy link

@vpetro vpetro commented Nov 28, 2024 •
edited
Loading

Summary

Timeout values are specified as Timeout | int | None in get and etc. httpx.Timeout however accepts value of float type.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@vpetro
Change timeout values to be ints
fd326e6 
Timeout values are specified as `Timeout | int | None` in `get` and etc.
`httpx.Timeout` however accepts value of `float` type.
@lovelydinosaur
Copy link
Contributor

lovelydinosaur commented Nov 29, 2024

Timeout values are specified as Timeout | int | None in get and etc.

Pointer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vpetro @lovelydinosaur