Skip to content

Use weakref for bound stream _response. #3733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nascheme wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use weakref for bound stream _response. #3733

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2ab572
Use weakref for bound stream _response.
nascheme Dec 18, 2025
98d65fe
Remove unintended "assert".
nascheme Dec 19, 2025
d4d1959
Add CHANGELOG note.
nascheme Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions httpx/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import time
import typing
import warnings
import weakref
from contextlib import asynccontextmanager, contextmanager
from types import TracebackType

Expand Down Expand Up @@ -146,7 +147,7 @@ def __init__(
self, stream: SyncByteStream, response: Response, start: float
) -> None:
self._stream = stream
self._response = response
self._response = weakref.ref(response)
self._start = start

def __iter__(self) -> typing.Iterator[bytes]:
Expand All @@ -155,7 +156,9 @@ def __iter__(self) -> typing.Iterator[bytes]:

def close(self) -> None:
elapsed = time.perf_counter() - self._start
self._response.elapsed = datetime.timedelta(seconds=elapsed)
response = self._response()
if response is not None:
response.elapsed = datetime.timedelta(seconds=elapsed)
self._stream.close()


Expand All @@ -169,7 +172,7 @@ def __init__(
self, stream: AsyncByteStream, response: Response, start: float
) -> None:
self._stream = stream
self._response = response
self._response = weakref.ref(response)
self._start = start

async def __aiter__(self) -> typing.AsyncIterator[bytes]:
Expand All @@ -178,7 +181,10 @@ async def __aiter__(self) -> typing.AsyncIterator[bytes]:

async def aclose(self) -> None:
elapsed = time.perf_counter() - self._start
self._response.elapsed = datetime.timedelta(seconds=elapsed)
response = self._response()
if response is not None:
assert 0
response.elapsed = datetime.timedelta(seconds=elapsed)
await self._stream.aclose()


Expand Down
Loading