Feat: Firo network#804
Merged
kvhnuke merged 2 commits intoJun 4, 2026
Merged
Conversation
|
Caution Review failedPull request was closed or merged during review WalkthroughAdds full FIRO/Spark support: wallet + Electrum, Spark WASM helpers, mint/spend flows, IndexedDB-based sync with worker, provider/API and network configs, and UI send/verify, activity, and deposit updates. Includes background/keyring wiring and tests/config tweaks. ChangesFiro/Spark end-to-end support
Sequence Diagram(s)sequenceDiagram
autonumber
participant UI as UI (Send Spark)
participant Wallet as BaseFiroWallet
participant WASM as Spark WASM
participant DB as IndexedDB
participant Electrum as FiroElectrum/API
UI->>Wallet: getTransactionsAddresses()
Wallet-->>UI: addresses
UI->>DB: read myCoins / sets / tags
UI->>WASM: js_createSparkSpendTransaction(recipients, coins, coverSets)
WASM-->>UI: serialized spend payload + scripts
UI->>Wallet: build final tx hex (spark payload + scripts)
UI->>Electrum: broadcast(rawTx)
Electrum-->>UI: txid
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
|
kvhnuke
approved these changes
Jun 4, 2026
7d8c92a
into
enkryptcom:firoorg-feature/add-firo-network
1 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Release Notes