refactor: use Go native build info for commit and date#8
Merged
Conversation
Replace ldflags injection of commit and date with runtime/debug.ReadBuildInfo(), which Go embeds automatically from VCS. Only version remains as an ldflag since there is no native way to get the git tag at runtime. This aligns the build pattern across all three CLIs (esq, atl, n8nctl).
There was a problem hiding this comment.
Code Review
This pull request refactors the versioning system to retrieve VCS information at runtime using the runtime/debug package instead of relying on build-time ldflags. The vcsInfo function was introduced to extract the commit hash and build date directly from the binary's build info. Feedback suggests enhancing this function to check the vcs.modified flag, which would allow the version output to indicate if the binary was built from a repository with uncommitted changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commitanddatewithruntime/debug.ReadBuildInfo()which Go embeds automatically from VCSversionremains as an ldflag (no native way to get the git tag at runtime)-X main.version={{.Version}}Test plan
go vet ./...passesgo build -ldflags "-s -w -X main.version=1.2.0"-s -wstripping does NOT affectruntime/debugbuild info