Fix review interactive setup and Codex defaults - #1749
Merged
Conversation
Entire-Checkpoint: 01KXGQW0RDC3PF5QKT23GN0B83
Entire-Checkpoint: 01KXGS1Y108CS4JZGG4988H6Q9
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the entire review command’s interactive-setup gating and updates Codex default/legacy review configuration so Codex runs prompt-only rather than relying on a removed curated /review skill.
Changes:
- Adds a compatibility repair that rewrites legacy Codex reviewer configs using
Skills: ["/review"]into prompt-only configs at runtime. - Centralizes review interactivity detection (
reviewCommandIsInteractive) and uses it across--edit, guided setup, multi/single-agent sink selection, and findings picking. - Updates defaults/tests so Codex (and other non-Claude agents) use a prompt-based default instead of a curated skill.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cmd/entire/cli/review/profile.go | Repairs legacy Codex /review skill configs in-memory and makes Codex defaults prompt-only. |
| cmd/entire/cli/review/fix.go | Uses unified review interactivity detection for findings selection. |
| cmd/entire/cli/review/configure_test.go | Adds coverage for Codex prompt-only defaults, legacy repair, and interactivity logic. |
| cmd/entire/cli/review/cmd.go | Introduces reviewCommandIsInteractive/reviewTTYIsInteractive and wires them into review flows. |
| cmd/entire/cli/review/cmd_test.go | Adds regression test ensuring legacy Codex configs still launch; updates invalid-skill coverage. |
| cmd/entire/cli/interactive/interactive.go | Adds IsTerminalReader helper for stdin TTY detection. |
Entire-Checkpoint: 01KXGSC7YR34K5TTMAVFH7PCMA
Entire-Checkpoint: 01KXGSRY52644B5B6A7CKHQV4B
Entire-Checkpoint: 01KXGT7DJ8E7EC047SBCZXN1Z3
Entire-Checkpoint: 01KXGTKA4VF60BYNEPDWQQ3NNC
peyton-alt
approved these changes
Jul 14, 2026
peyton-alt
enabled auto-merge
July 14, 2026 18:14
dipree
disabled auto-merge
July 14, 2026 20:01
peyton-alt
added a commit
that referenced
this pull request
Jul 14, 2026
… native invocation The user asked whether configured codex $code-reviewer skills are retained after #1749's legacy-config repair merged in. They are, by two independent guards; these tests lock that so a future migration edit can't clobber real skills: - normalizeLegacyCodexDefaultSkills only rewrites codex's exact ["/review"] artifact; a $code-reviewer config and multi-skill configs pass through untouched. - codexNativeSkillInvocations rewrites only slash-form to $; $name and plain text pass through verbatim. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Entire-Checkpoint: 01KXHANJCZ4G2GCS548V1CKZSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://entire.io/gh/entireio/cli/trails/854
This draft pull request was opened by Entire after CI was requested for the linked trail. Feel free to edit the title or body — the link above is what keeps the trail and PR connected.