Va(Time/Date)Input bugs

[smellyshovel]

1

Latest version.

            <va-time-input
              v-if="useIndexProxy"
              v-model="rawSearchRequestEntry.timeTo"
              :disabled="!rawSearchRequestEntry.dateTo"
              manual-input
              autocomplete="off"
              icon=""
            />

When disabled, the component still allows to modify the input manually (when the manual-input prop is on):

vatimeinputbug.mp4

Maybe there's the same issue with date-input, didn't check.

2

Less of a bug, but still.

When icon="" is set, the icon is indeed not shown. Though it's still possible to target it with keyboard navigation.
Would be nice to have some way to disable the icon completely.

3

For Date input, or even rather date picker, it's impossible to change the back n' forth icons (chevron_left and chevron_right). Trying to rewrite these icons using the icons config - doesn't help.
Would be nice to either be able to change these icons via props or using the icons config. The last option is preferable.

4

Another minor thing.
The input field itself is a bit smaller that its wrapper. But both of them share the same cursor style. When clicking the input (with manual input mode), no calendar/time-picker is opened. But when clicking the wrapper, it openes.
A bit mislieading. If you don't know there's a wrapper, it might feel like the dropdown opens randomly.

inputs.mp4

[aluarius]

Can't repro first problem (manual-input affects only input's readonly state, no common logic with disabled), but i will add an additional restriction to proceeding input text change in case of props.disabled === true.

[smellyshovel]

@aluarius I meant that the calendar/time-dropdown doesn't open indeed, but it's still possible to enter the date/time manually using the input field. When the component is disabled, that shouldn't be the case.

[aluarius]

Yes, i've understand, but can't repro it anyway -> in case disabled and manual-input props are true, i'm still not able to focus input and change anything inside it.

Anyway, as was said, i have added additional restriction.

Safari/Chome?

[smellyshovel]

@aluarius
Chrome.
Can you create an experimental release so that I could check whether your additional restriction fixes my issue?

[aluarius]

Discussion moved to slack.