[#2018] usePopover - add default position#2019
Merged
m0ksem merged 2 commits intoepicmaxco:developfrom Jun 30, 2022
Merged
Conversation
RVitaly1978
approved these changes
Jun 29, 2022
m0ksem
reviewed
Jun 30, 2022
| prev = rect | ||
| }) | ||
|
|
||
| watch(target, (newVal) => { |
Member
There was a problem hiding this comment.
This thing is important. It will update domRect exactly after it appears in DOM.
m0ksem
approved these changes
Jun 30, 2022
Member
m0ksem
left a comment
m0ksem
left a comment
There was a problem hiding this comment.
Thanks for notice! I made it a bit simpler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2018
Description
va-dropdown__content-wrapper without
topandleftproperties might position wrongly, which causes the original issueTypes of changes