Skip to content

Feat/va badge updates#2808

Merged
aluarius merged 19 commits intoepicmaxco:developfrom
aluarius:feat/va-badge-updates
Dec 27, 2022
Merged

Feat/va badge updates#2808
aluarius merged 19 commits intoepicmaxco:developfrom
aluarius:feat/va-badge-updates

Conversation

@aluarius
Copy link
Copy Markdown
Contributor

Closes: #2769

Description

  • new placement prop, that allows to set any badge position (old left and bottom props are still working until 1.6.0);
  • new offset prop, that allows to amend badge position relatively to the main axis;
  • related refactoring and minor bugfixing;
  • docs updates;
  • updates to the Vuestic site (somewhere was used a hack for what now offset prop does).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@aluarius aluarius self-assigned this Dec 23, 2022
Copy link
Copy Markdown
Contributor

@rustem-nasyrov rustem-nasyrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, my branch was outdated.

@rustem-nasyrov rustem-nasyrov self-requested a review December 23, 2022 07:45
<va-badge text="icon">
<va-icon name="face" />
</va-badge><br><br>
<VbCard title="Transparent">
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't would be better to control transparency by CSS variables?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo not convenient for dynamic states.

@aluarius aluarius merged commit c88a86d into epicmaxco:develop Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VaBadge positioning is weird

2 participants