Merged
Conversation
fix: deprecated composable bug fix
rustem-nasyrov
suggested changes
Dec 23, 2022
packages/ui/src/components/va-badge/hooks/useFloatingPositionStyles.ts
Outdated
Show resolved
Hide resolved
packages/ui/src/components/va-badge/hooks/useFloatingPositionStyles.ts
Outdated
Show resolved
Hide resolved
| <va-badge text="icon"> | ||
| <va-icon name="face" /> | ||
| </va-badge><br><br> | ||
| <VbCard title="Transparent"> |
Contributor
There was a problem hiding this comment.
Isn't would be better to control transparency by CSS variables?
Contributor
Author
There was a problem hiding this comment.
Imo not convenient for dynamic states.
rustem-nasyrov
approved these changes
Dec 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #2769
Description
placementprop, that allows to set any badge position (old left and bottom props are still working until 1.6.0);offsetprop, that allows to amend badge position relatively to the main axis;offsetprop does).Types of changes