Merged
Conversation
LighthouseKeeperYN
requested review from
aluarius,
asvae,
m0ksem and
rustem-nasyrov
rustem-nasyrov
approved these changes
Jan 27, 2023
m0ksem
approved these changes
Jan 30, 2023
Member
m0ksem
left a comment
m0ksem
left a comment
There was a problem hiding this comment.
Looks like a good start :) We gonna need to fix components typing in tests and make a better coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1145
I restored and added missing component unit tests, so far 90% of tests only check if component was mounted without an error. I commented out some tests cases I couldn't get to work, it's probably easier to write new ones.
Types of changes