Change Old typography classes in input example to new typography classes#3074
Merged
m0ksem merged 2 commits intoepicmaxco:developfrom Feb 27, 2023
Merged
Change Old typography classes in input example to new typography classes#3074m0ksem merged 2 commits intoepicmaxco:developfrom
m0ksem merged 2 commits intoepicmaxco:developfrom
Conversation
Contributor
Author
|
Hello there, |
m0ksem
approved these changes
Feb 27, 2023
Member
m0ksem
left a comment
There was a problem hiding this comment.
Thanks!
Next time, don't spend to much effort in PR description :)
Fix Issue: Old typography classes are used in input example #3071
Can be simplified to two words "closes #3071"
You also don't need to write changes in PR descriptions, because they can been seen in "File changed" tab.
Usually for small PRs title is enough.
Contributor
Author
|
Thank you, from next time will make sure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue: Old typography classes are used in input example #3071
Description
Made changes in two file
modified: packages/docs/page-config/ui-elements/input/examples/InputClass.vue
This was before changes
After chnages
modified: packages/docs/locales/en.json
Before Changes
After changes
Changed to:
va-text-centerandva-text-rightto align ...Types of changes