Skip to content

Change Old typography classes in input example to new typography classes#3074

Merged
m0ksem merged 2 commits intoepicmaxco:developfrom
scorcism:develop
Feb 27, 2023
Merged

Change Old typography classes in input example to new typography classes#3074
m0ksem merged 2 commits intoepicmaxco:developfrom
scorcism:develop

Conversation

@scorcism
Copy link
Copy Markdown
Contributor

@scorcism scorcism commented Feb 26, 2023

Fix Issue: Old typography classes are used in input example #3071

Description

Made changes in two file

  •     modified:   packages/docs/locales/en.json
    
  •     modified:   packages/docs/page-config/ui-elements/input/examples/InputClass.vue
    

modified: packages/docs/page-config/ui-elements/input/examples/InputClass.vue
This was before changes

<template>
  <div class="va-input-css-example">
    <va-input
      class="mr-3"
      input-class="text--right color mb-2"
      :model-value="$t('input.examples.inputClass.exampleTexts[0]')"
    />
    <va-input
      class="border-gray"
      input-class="color p-2"
      :model-value="$t('input.examples.inputClass.exampleTexts[1]')"
      type="textarea"
    />
  </div>
</template>

After chnages

<template>
  <div class="va-input-css-example">
    <va-input
      class="mr-3"
      input-class="va-text-right color mb-2"
      :model-value="$t('input.examples.inputClass.exampleTexts[0]')"
    />
    <va-input
      class="border-gray"
      input-class="color p-2"
      :model-value="$t('input.examples.inputClass.exampleTexts[1]')"
      type="textarea"
    />
  </div>
</template>

modified: packages/docs/locales/en.json
Before Changes

"inputClass": {
        "title": "Input Class",
        "text": "To assign a class directly to input, rather than its wrapper, use the `input-class` property. For example, you can use the build-in component class (or any other class you've created) to align the input text &mdash; `text--center` and `text-right` to align the center or right.",
        "exampleTexts": [
          "This input must have right-aligned green text with bottom indent.",
          "Native input element must have green text. VaInput wrapper has a gray border."
        ]
      },

After changes

"inputClass": {
        "title": "Input Class",
        "text": "To assign a class directly to input, rather than its wrapper, use the `input-class` property. For example, you can use the build-in component class (or any other class you've created) to align the input text &mdash; `va-text-center` and `va-text-right` to align the center or right.",
        "exampleTexts": [
          "This input must have right-aligned green text with bottom indent.",
          "Native input element must have green text. VaInput wrapper has a gray border."
        ]
      },

Changed to:

  • ... text--center and text--right to align ... --> ... va-text-center and va-text-right to align ...
  • text--right --> va-text-right

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@scorcism scorcism changed the title change Old typography classes in input example to new typography classes Change Old typography classes in input example to new typography classes Feb 26, 2023
@scorcism
Copy link
Copy Markdown
Contributor Author

Hello there,
I'm new to open source,
If anything, please let me know
Thank you

Copy link
Copy Markdown
Member

@m0ksem m0ksem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Next time, don't spend to much effort in PR description :)

Fix Issue: Old typography classes are used in input example #3071

Can be simplified to two words "closes #3071"

You also don't need to write changes in PR descriptions, because they can been seen in "File changed" tab.

Usually for small PRs title is enough.

@m0ksem m0ksem added the docs packages/docs label Feb 27, 2023
@m0ksem m0ksem merged commit 630fd31 into epicmaxco:develop Feb 27, 2023
@scorcism
Copy link
Copy Markdown
Contributor Author

Thank you, from next time will make sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs packages/docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants