Skip to content

Add color prop to VaDivider component and bind it to CSS border color #3154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustem-nasyrov merged 5 commits into from
Mar 24, 2023
Merged

Add color prop to VaDivider component and bind it to CSS border color #3154

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5e6938e
This commit adds a color prop to the VaDivider component, allowing us…
Yasir761 Mar 13, 2023
b4cd213
The previous implementation used a redundant color prop for specifyin…
Yasir761 Mar 13, 2023
8a4bc64
Revert "The previous implementation used a redundant color prop for s…
m0ksem Mar 20, 2023
37b53ae
chore(divider): use v-bind instead of style bind. Remove extra css va…
m0ksem Mar 20, 2023
521e978
fix(divider): use compiled color
m0ksem Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/ui/src/components/va-divider/VaDivider.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
class="va-divider"
:class="classComputed"
:aria-orientation="vertical ? 'vertical' : 'horizontal'"
:style="`color: ${color}; --va-divider-border-top-color: ${color}`"
>
<div
v-if="hasSlot && !vertical"
Expand Down Expand Up @@ -32,6 +33,7 @@ export default defineComponent({
default: 'center',
validator: (value: string) => ['left', 'right', 'center'].includes(value),
},
color: { type: String, default: '' }
},
setup: (props, { slots }) => ({
hasSlot: computed(() => !!slots.default),
Expand Down Expand Up @@ -81,7 +83,7 @@ export default defineComponent({
flex: 1;
border-top-width: var(--va-divider-line-width);
border-top-style: var(--va-divider-border-top-style);
border-top-color: var(--va-divider-border-top-color);
border-top-color: var(--va-divider-border-top-color)
}

&--dashed {
Expand Down