feat(ui): expose aria labels as props#3175
Merged
m0ksem merged 4 commits intoepicmaxco:developfrom Apr 4, 2023
Merged
Conversation
rustem-nasyrov
suggested changes
Mar 15, 2023
63 tasks
rustem-nasyrov
approved these changes
Apr 4, 2023
m0ksem
added
feature
m0ksem
added a commit
to asvae/vuestic-ui
that referenced
this pull request
Apr 6, 2023
* feat(ui): expose aria labels as props * docs(select): description for aria label props * fix(counter): label translation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply expose aria-labels as props, so it can be changed by user. Still use translation (also, it makes it noticeable in docs, that there are translations for aria things). The pattern is
aria[thingName]Label.closes #3104
Wonder if there is some other aria things to translate.
We need also improve docs and add few words about props with default value like
$t:goToSpecificPagewihch can beПерехід до {page} сторінки. There were a few places... Gonna make it after review. in different PR.Small demo for Select, for other components it will be easier to add docs in scope of split translation PR:
I also need another mind, maybe need to rename some props.