Merged
Conversation
Contributor
rustem-nasyrov
left a comment
rustem-nasyrov
left a comment
There was a problem hiding this comment.
Examples are look a little bit odd. Maybe we can improve them? Bright colors they are take away attention too much.
zvenigorodskaia
approved these changes
Apr 7, 2023
Member
|
Looks like outline input should use |
m0ksem
approved these changes
Apr 11, 2023
Member
m0ksem
left a comment
m0ksem
left a comment
There was a problem hiding this comment.
IMO, two cards is enough to get the idea of VaConfig. I'm trying to provide less code for user to read recently. Better have two examples instead. But it is my personal preference – rich examples are good too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
close #2859
screenshot
Types of changes