chore: Use tailwind instead of inline styles#3353
Conversation
It is OK. Thanks! |
83e2898 to
8385c20
Compare
|
Gotcha, will sync them all up.. :) |
|
I've been caught up with work.. will be able to finish this within the week.. I hope that's okay.. thanks. |
Hi @a-3140. In case you are busy, we have another PR fixing this problem. I suggest finish some work in ui-elements folder, so @xiongmao86 can work on another sections (btw, he already did some work on another sections like services, ag-grid etc.) |
8385c20 to
6e02046
Compare
6e02046 to
bcbdb6b
Compare
|
Apologies @m0ksem , took a while as I started on a new company and focused there on a bit.. I finished the MR now, it should be on top of the separate changes regarding the usage of tailwind. For notes on changes of couple of pixels, it's included in the description.. I'll mark it as ready for review now.. thanks. |
| <va-breadcrumbs-item label="Four" /> | ||
| <va-breadcrumbs-item label="Five"> | ||
| <span style="font-style: italic; color: var(--va-danger);">Slotted content</span> | ||
| <span class="italic text-[var(--va-danger)]"> |
There was a problem hiding this comment.
@m0ksem, double check if text-[var(--va-danger)] can be replaced with text-danger.
packages/docs/page-config/ui-elements/dropdown/examples/PlacementAndOffset.vue
Show resolved
Hide resolved
packages/docs/page-config/ui-elements/dropdown/examples/PreventOverflow.vue
Show resolved
Hide resolved
|
@asvae, I did a QA. Looks solid, can be merged. |
asvae
left a comment
There was a problem hiding this comment.
Checked several pages. Things look all right!
|
Awesome. Thanks! |
Some notable changes that aren't 1:1 from inline styles to tailwind usage:
Types of changes