Feat#3439/usecolors test coverage#3491
Merged
m0ksem merged 7 commits intoepicmaxco:developfrom Jun 13, 2023
Merged
Conversation
…s as parameter for CreateTestComposable
m0ksem
approved these changes
Jun 13, 2023
Member
|
Looks perfect. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create tests for useColor composable
applyPresetfunction and thecurrentPresetNamecomputedcreateTestComposablefunction (with retro-compatibility) to make multiple composables share stateDescription
applyPresetandcurrentPresetNameneeded both theuseColorandglobalConfigcomposables to share state. This would not be possible by callingapplyPresettwice with different arguments: the two composable instances would be on separate app instances. However, the feature was added without breaking changes.A nice improvement would be adding the proper typing to reap the benefits of autocompletion
Types of changes
resolve #3439