Skip to content

improve accessiblity of VaAlert component#3541

Merged
m0ksem merged 2 commits intoepicmaxco:developfrom
xiongmao86:fix/a11y-alert
Jun 30, 2023
Merged

improve accessiblity of VaAlert component#3541
m0ksem merged 2 commits intoepicmaxco:developfrom
xiongmao86:fix/a11y-alert

Conversation

@xiongmao86
Copy link
Copy Markdown
Contributor

Improve accessibility on VaAlert, and add docs for it.
Fixes #3231

I am not very sure this pr is a breaking change, is it?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem m0ksem self-requested a review June 28, 2023 11:14
@m0ksem
Copy link
Copy Markdown
Member

m0ksem commented Jun 30, 2023

Breaking changes means that user app maybe not work after these changes. Here it is okay.

@m0ksem m0ksem merged commit 87f402b into epicmaxco:develop Jun 30, 2023
@xiongmao86
Copy link
Copy Markdown
Contributor Author

Thanks for reviewing my pr. @m0ksem.

@m0ksem
Copy link
Copy Markdown
Member

m0ksem commented Jun 30, 2023

Thanks for reviewing my pr. @m0ksem.

Thanks for participating and making wonderful PRs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

a11y: va-alert

2 participants