feat(colors): add onColors support#3911
Merged
m0ksem merged 4 commits intoepicmaxco:developfrom Sep 28, 2023
Merged
Conversation
asvae
reviewed
Sep 27, 2023
Member
asvae
left a comment
asvae
left a comment
There was a problem hiding this comment.
I'm pretty sure we can improve the quality of this.
I.e. better docs, stories, specs for edge cases. Is that something you would consider important, or you would rather merge it as is and deal with leftovers later?
(maybe you can formulate leftovers in different issue at least)
Member
Author
|
I'd like to have a brief video guide on colors in general. Docs are fine and there is nothing to test, actually. There are 6 lines of this feature covered with dozens lines of docs and tests. |
Member
Author
|
Let's improve stories and this feature as needed. This is enough for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an issue with threshold, for some colors I want color to be dark, for some light - independent from each other.