Fix: Overflow behaviour of VaCollapse#3938
Merged
m0ksem merged 5 commits intoepicmaxco:developfrom Oct 10, 2023
Merged
Conversation
m0ksem
reviewed
Oct 8, 2023
Co-authored-by: Maksim Nedoshev <m0ksem1337@gmail.com>
m0ksem
approved these changes
Oct 10, 2023
Member
|
@asvae, I added new story about collapse overflow, if you think it needs some changes, please, make a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3931
Fix overflow behaviour of VaCollapse
Description
The VaCollapse body wrapper had a overflow hidden which would have been causing the extra content to be clipped. Changed the overflow behaviour to auto so that users will get a scrollbar when the size exceeds more than allotted.
Markup:
Details
&__body-wrapper { transition: var(--va-collapse-body-wrapper-transition); overflow: scroll; // Changed this to scroll from hidden &--bordered { border-bottom: 1px solid var(--va-background-border); .va-collapse--colored-header:not(.va-collapse--expanded) & { border-bottom: none; } .va-collapse--colored-body.va-collapse--expanded & { border-bottom: none; } } }Types of changes