Skip to content

Fix: Overflow behaviour of VaCollapse#3938

Merged
m0ksem merged 5 commits intoepicmaxco:developfrom
keerthanak-tw:fix/va-collapse-overflow
Oct 10, 2023
Merged

Fix: Overflow behaviour of VaCollapse#3938
m0ksem merged 5 commits intoepicmaxco:developfrom
keerthanak-tw:fix/va-collapse-overflow

Conversation

@keerthanak-tw
Copy link
Copy Markdown
Contributor

@keerthanak-tw keerthanak-tw commented Oct 3, 2023

closes #3931

Fix overflow behaviour of VaCollapse

Description

The VaCollapse body wrapper had a overflow hidden which would have been causing the extra content to be clipped. Changed the overflow behaviour to auto so that users will get a scrollbar when the size exceeds more than allotted.

Markup:

Details
&__body-wrapper {
    transition: var(--va-collapse-body-wrapper-transition);
    overflow: scroll;   // Changed this to scroll from hidden

    &--bordered {
      border-bottom: 1px solid var(--va-background-border);

      .va-collapse--colored-header:not(.va-collapse--expanded) & {
        border-bottom: none;
      }

      .va-collapse--colored-body.va-collapse--expanded & {
        border-bottom: none;
      }
    }
  }

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem
Copy link
Copy Markdown
Member

m0ksem commented Oct 10, 2023

@asvae, I added new story about collapse overflow, if you think it needs some changes, please, make a separate issue.

@m0ksem m0ksem merged commit 80e80f5 into epicmaxco:develop Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VaCollapse hides overflow by default

2 participants