Skip to content

fix(VaSelect): fix objects-as-options cannot set status correctly(#4198)#4200

Merged
m0ksem merged 1 commit intoepicmaxco:developfrom
gweesin:fix#4198/fix-objects-as-options-error
Apr 8, 2024
Merged

fix(VaSelect): fix objects-as-options cannot set status correctly(#4198)#4200
m0ksem merged 1 commit intoepicmaxco:developfrom
gweesin:fix#4198/fix-objects-as-options-error

Conversation

@gweesin
Copy link
Copy Markdown
Contributor

@gweesin gweesin commented Apr 3, 2024

closed #4198

Description

Objects should always retain their references because the default method of checking object equality relies on comparing object references when the value of 'valueBy' does not exist, thereby comparing two object references.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem m0ksem merged commit 72ffc59 into epicmaxco:develop Apr 8, 2024
@gweesin gweesin deleted the fix#4198/fix-objects-as-options-error branch June 15, 2025 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Va-Select as 'objects-as-options'. Options are not selectable

2 participants