Skip to content

bug: Fix modal close button storybook example#4227

Merged
m0ksem merged 1 commit intoepicmaxco:developfrom
ahmadJT:fix/modal-close-btn-doc
Apr 26, 2024
Merged

bug: Fix modal close button storybook example#4227
m0ksem merged 1 commit intoepicmaxco:developfrom
ahmadJT:fix/modal-close-btn-doc

Conversation

@ahmadJT
Copy link
Copy Markdown
Contributor

@ahmadJT ahmadJT commented Apr 16, 2024

Description

  • updated the close button storybook example so the modal closes on click

Markup:

Details

Issue

#3995

export const CloseButton: StoryFn = () => ({
  components: { VaModal },
  data () {
    return {
      show: false,
    }
  },
  template: `
    <button @click="show = true">
      show modal
    </button>
    <VaModal :model-value="show" @cancel="show = false" :close-button="true">
      Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, voluptatum. Lorem ipsum dolor sit amet consectetur adipisicing elit. Quisquam, voluptatum.
    </VaModal>
  `,
})

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem m0ksem merged commit c464383 into epicmaxco:develop Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants