Skip to content

fix(VaDataTable): use background color and opacity without mixin#4237

Merged
m0ksem merged 1 commit intoepicmaxco:developfrom
ahmadJT:fix/striped-table-hover
May 5, 2024
Merged

fix(VaDataTable): use background color and opacity without mixin#4237
m0ksem merged 1 commit intoepicmaxco:developfrom
ahmadJT:fix/striped-table-hover

Conversation

@ahmadJT
Copy link
Copy Markdown
Contributor

@ahmadJT ahmadJT commented Apr 25, 2024

Description

used background color and opacity without mixin
Screenshot 2024-04-25 at 06 39 05
Screenshot 2024-04-25 at 06 39 12

closes #4236

Markup:

Details
    &.striped {
      .va-data-table__table-tbody {
        .va-data-table__table-tr {
          &:nth-of-type(2n) {
            &:not(.selected) {
              td {
                // Position relative doesn't work on tr in Safari
                position: relative;
                background: var(--va-data-table-striped-tr-background-color);
                opacity: var(--va-data-table-striped-tr-opacity);
              }
            }
          }
        }
      }
    }

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@m0ksem m0ksem self-requested a review April 26, 2024 14:15
@m0ksem m0ksem merged commit 29009b6 into epicmaxco:develop May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VaDataTable active class and hoverable not working on striped rows

2 participants