Skip to content

fix(slider): out of range values handling #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m0ksem merged 1 commit into from
Jun 3, 2024
Merged

fix(slider): out of range values handling #4296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions packages/ui/src/components/va-slider/VaSlider.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,16 @@ const trackStyles = computed(() => ({
: getHoverColor(getColor(props.color)),
}))

const calculatePercentage = (value: number) => {
const min = minComputed.value
const max = maxComputed.value
return ((clamp(min, value, max) - min) / (max - min)) * 100
}

const processedStyles = computed(() => {
if (Array.isArray(val.value)) {
const val0 = ((val.value[0] - minComputed.value) / (maxComputed.value - minComputed.value)) * 100
const val1 = ((val.value[1] - minComputed.value) / (maxComputed.value - minComputed.value)) * 100
const val0 = calculatePercentage(val.value[0])
const val1 = calculatePercentage(val.value[1])

return {
[pinPositionStyle.value]: `${val0}%`,
Expand All @@ -282,7 +288,7 @@ const processedStyles = computed(() => {
visibility: props.showTrack ? 'visible' : 'hidden',
} as CSSProperties
} else {
const val0 = ((val.value - minComputed.value) / (maxComputed.value - minComputed.value)) * 100
const val0 = calculatePercentage(val.value)

return {
[trackSizeStyle.value]: `${val0}%`,
Expand All @@ -294,8 +300,8 @@ const processedStyles = computed(() => {

const dottedStyles = computed(() => {
if (Array.isArray(val.value)) {
const val0 = ((val.value[0] - minComputed.value) / (maxComputed.value - minComputed.value)) * 100
const val1 = ((val.value[1] - minComputed.value) / (maxComputed.value - minComputed.value)) * 100
const val0 = calculatePercentage(val.value[0])
const val1 = calculatePercentage(val.value[1])

return [
{
Expand All @@ -310,7 +316,7 @@ const dottedStyles = computed(() => {
},
] as CSSProperties[]
} else {
const val0 = ((val.value - minComputed.value) / (maxComputed.value - minComputed.value)) * 100
const val0 = calculatePercentage(val.value)

return {
[pinPositionStyle.value]: `${val0}%`,
Expand Down