Skip to content

feat(input): add native autocomplete attribute support #4370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m0ksem merged 1 commit into from
Sep 13, 2024
Merged

feat(input): add native autocomplete attribute support #4370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat(input): add native autocomplete attribute support
  • Loading branch information
@padinko
padinko committed Sep 3, 2024
commit c284e7a95f8801f9cb02988630157643eb141191
3 changes: 2 additions & 1 deletion packages/ui/src/components/va-input/VaInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ const props = defineProps({
pattern: { type: String },
inputmode: { type: String, default: 'text' },
counter: { type: Boolean, default: false },
autocomplete: { type: String },

// style
ariaResetLabel: useTranslationProp('$t:reset'),
Expand Down Expand Up @@ -227,7 +228,7 @@ const computedChildAttributes = computed(() => (({

const computedInputAttributes = computed(() => (({
...computedChildAttributes.value,
...pick(props, ['type', 'disabled', 'readonly', 'placeholder', 'pattern', 'inputmode', 'name']),
...pick(props, ['type', 'disabled', 'readonly', 'placeholder', 'pattern', 'inputmode', 'name', 'autocomplete']),
...pick(attrs, ['minlength', 'minlength']),
}) as InputHTMLAttributes))

Expand Down