Skip to content

Switch from Travis-CI to GitHub Actions#66

Merged
shroffk merged 5 commits into
epics-base:masterfrom
ralphlange:travis-to-gha
Jul 21, 2022
Merged

Switch from Travis-CI to GitHub Actions#66
shroffk merged 5 commits into
epics-base:masterfrom
ralphlange:travis-to-gha

Conversation

@ralphlange

Copy link
Copy Markdown
Contributor

ssia

@ralphlange ralphlange requested a review from shroffk July 18, 2022 17:13
@ralphlange ralphlange self-assigned this Jul 18, 2022
- maven-changes-plugin -> 2.12.1
- maven-jxr-plugin -> 3.2.0
- maven-compiler-plugin -> 3.10.1
- maven-source-plugin -> 3.2.1
- maven-jar-plugin -> 3.2.2
- maven-javadoc-plugin -> 2.10.4
- maven-surefire-plugin -> 2.19.1
- maven-project-info-reports -> 3.3.0
- maven-site-plugin -> 4.0.0-M1
- maven-bundle-plugin -> 5.1.6
- junit -> 4.13.2
@ralphlange

Copy link
Copy Markdown
Contributor Author

I think this is ready now...

@ralphlange

Copy link
Copy Markdown
Contributor Author

Java 16 is an intentionally ignored (for now) failure (see #67).
The site building job intentionally only runs for the master branch - skipping it on a pull request is expected.

@shroffk

shroffk commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

@ralphlange should we just skip jdk16 for the time being ( we keep the issue ticket open to document all that you have done )

@ralphlange

Copy link
Copy Markdown
Contributor Author

Your call.

I configured it to not fail the build and kept it so we always have it on our radar that there is an issue to be fixed.
If you prefer not to see that - fine with me.

@shroffk

shroffk commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

Could you comment out the jdk16 inclusion - this was the comments remain in place as a reminder but the CI for the main project appears green.
I can't updated your branch so I am pushing this back to you :)
Thanks again

@ralphlange

Copy link
Copy Markdown
Contributor Author

I don't understand.

Again: I added the configuration to have that job not fail the build. I.e., the CI for the main project appears green even though the Java 16 build is failing. (See https://github.com/ralphlange/jca/actions/runs/2703430640 for an example.)

@shroffk shroffk merged commit bcda757 into epics-base:master Jul 21, 2022
@shroffk

shroffk commented Jul 21, 2022

Copy link
Copy Markdown
Contributor

the thing is all PR's will have the "some failing" bit... which is what I was referring to.
In anycase...I have merged it for the time being... if it causes confusion with future PR's then it I will go and comment it out.
Thanks!

@ralphlange

Copy link
Copy Markdown
Contributor Author

Thanks!
I'm fine with hiding the failures should they cause confusion. (I would still rather have them fixed than hidden.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants