Add a timeout for the socket connection#78
Merged
Conversation
Update timeout property to be in secs and defined as a float.
Contributor
|
Looks good to me: No change unless one reduces the now-configurable connection timeout |
Contributor
Author
|
@kasemir thanks for taking a look at this. I set the configurable connection timeout back to 2 minutes to resemble the original behaviour of the |
Contributor
I'd say the default can be shorter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue described in #36 where the method to connect to a socket can block for ~ 2 minutes. Instead, I have added a timeout for the connection, which is configurable in the properties. A default of 5 seconds has been used for the timeout if not specified.