Don't allow both original and JSON commands to be registered simultaneously#15
Conversation
| R4-1: Changes since R4-0 | ||
| ------------------------ | ||
|
|
||
| **This version has not yet been released** |
There was a problem hiding this comment.
NB: Remove this comment before releasing.
Add other PR changes to these notes too...
|
@anjohnson - while I think it's a good idea to prevent both json/non-json logs being initialised at the same time, I have to admit that I find it a bit odd that we are making this restriction at build-time instead of only at run-time. Wouldn't it be more flexible implement only the check that prevents the registration of both json/non-json logging tasks? Otherwise if you want to change your logging you need to recompile the entire application or library, instead of simply changing the configuration in the startup script. If someone wants that flexibility, it seems a bit restrictive to disallow it... |
Log/print warning or error messages to explain what's wrong. Fixes GitHub issue epics-modules#14
|
@simon-ess Thanks for the comment, but please read the discussions in issues #8, #10 and #14 which document how we got to this point. If a site does want to be able to choose which logging format to use at init-time they can submit a PR for that, but it's not trivial to do. The original logging format is not properly parsable, which is why I want it to die out. |
2 participants
Fixes #14 and #10, warns user of bad IOC configurations.