Skip to content

test: added tests for EIA and flow to run it#97

Merged
tutkat merged 4 commits into
mainfrom
addEIATests
Jul 7, 2026
Merged

test: added tests for EIA and flow to run it#97
tutkat merged 4 commits into
mainfrom
addEIATests

Conversation

@tutkat

@tutkat tutkat commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@tutkat tutkat requested review from a team as code owners June 30, 2026 16:26
@ctreatma

ctreatma commented Jun 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Would you mind running git rm patches/services/fabricv4/20260128_fix_cloud_router_search_sort_criteria_enum.patch to remove an old, broken Fabric patch as part of this PR? CI fails for #96 because that patch is invalid, but the patch failure was previously hidden by the Metal client generation. This PR covers that invalid patch failure by having other patches that are applied successfully after it; if you remove the broken patch in this PR it will have no impact on the generated code and it will avoid unexpected errors later.

@tutkat

tutkat commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Would you mind running git rm patches/services/fabricv4/20260128_fix_cloud_router_search_sort_criteria_enum.patch to remove an old, broken Fabric patch as part of this PR? CI fails for #96 because that patch is invalid, but the patch failure was previously hidden by the Metal client generation. This PR covers that invalid patch failure by having other patches that are applied successfully after it; if you remove the broken patch in this PR it will have no impact on the generated code and it will avoid unexpected errors later.

as you see I removed it, but we have the problem now with builds

@ctreatma

ctreatma commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@tutkat since that patches/post build failure was related to Metal, I went ahead and merged #96 to remove Metal and then rebased this PR on the latest from main. It looks like builds are now failing due to the removed Fabric patch, so it looks like some parts of that patch were still in use but some were broken. For now it's probably best to restore the patch and clean it up in a separate PR.

@tutkat @claude
revert: restore 20260128 cloud router sort-criteria patch to fix code…
1e30763 
…gen build

Removing this patch broke the test-codegen check: the 11 committed sort-criteria
models rely on its enum-default fix, so regeneration without it produced output
differing from the committed code. Restore it to keep the build green.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@tutkat tutkat enabled auto-merge July 6, 2026 17:29
@tutkat tutkat merged commit 17955a5 into main Jul 7, 2026
4 checks passed
@tutkat tutkat deleted the addEIATests branch July 7, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ctreatma ctreatma ctreatma approved these changes
@srushti-patl srushti-patl srushti-patl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tutkat @ctreatma @srushti-patl