Support Auth #11

aaronmallen · 2016-08-25T06:26:58Z

Fixed

Change branch syntax to match real command #8 Change branch syntax to match real git command.

Added

Support for authenticated request.

resolves #8

eric-wieser · 2016-08-25T06:46:39Z

programs/github

 local action = select(1, ...)

-local usage = "Usage: github clone <user>/<repo> [<branch>|<tag>] [<destination>]"
+local usage = "Usage: github clone <user>/<repo> [-b <branchname>] [-t <tagname>] [-a <username>:<password>] [<destination>]"


[-b <branchname> | -t <tagname>]

eric-wieser · 2016-08-25T06:52:51Z

It's tempting just to throw docopt.lua at this to parse the command line, and require another dependency

aaronmallen · 2016-08-25T06:54:09Z

hold a tick... push incoming

aaronmallen · 2016-08-25T06:59:16Z

should be good now.

eric-wieser · 2016-08-25T07:00:22Z

programs/github

+				if arg == flag then
+					isFlag = true
+					flagName = flagType.name
+					return isFlag, flagName


Why not just return flagType.name

eric-wieser · 2016-08-25T07:02:54Z

Scratch that, docopt.lua never came into being

eric-wieser · 2016-08-25T07:07:26Z

programs/github

 end

+-- get flag arguments
+local function findFlag(arg)


I'm not sure it's an improvement, but this whole function could be written:

local flagNames = { ['--branch'] = 'branch', ['-b'] = 'branch' ['--tag'] = 'tag', ['-t'] = 'tag', ['--auth'] = 'auth' ['-a'] = 'auth' } local findFlag = function(arg) return flagNames[arg] end

aaronmallen · 2016-08-25T07:24:56Z

ready for CR again

aaronmallen · 2016-08-25T20:52:58Z

I am now accounting for your purposed github clone foo/bar -b -b scenario by also validating the arg ~= flagValue. The first -b flag in this command would set the flagValue so it would be add the second argument to the flags table but then the second argument would be ignored when iterated over.

I also REALLY liked your simplification of the findFlag function.

aaronmallen · 2016-08-25T21:06:48Z

programs/github

+end
+
+if flags.branch and flags.tag then
+	return printError('please specify a branch or tag.')


@eric-wieser I'm not sure how I feel about the error message here... care to offer a better one?

Yeah, this conveys the wrong message. "--branch and --tag cannot both be specified" would be more accurate.

Note that git clone doesn't actually "support" tags, but git clone -b a_tag tends to do the right thing anyway

Yeah and honestly providing the tag argument is more of a formality anyway.
Either branch or tag are going to be used for treeName so it's really just
calling the same variable a different name.

On Thu, Aug 25, 2016, 17:42 Eric Wieser notifications@github.com wrote:

In programs/github
#11 (comment)
:

+local passed = {...}
+local args = {}
+local flags = {}
+local flagValue = ''
+for k, arg in pairs(passed) do

local flagName = findFlag(arg)

if flagName and arg ~= flagValue then

flags[flagName] = passed[k + 1]

flagValue = flags[flagName]

elseif arg ~= action and arg ~= flagValue then

table.insert(args, arg)

end
+end

+if flags.branch and flags.tag then

return printError('please specify a branch or tag.')

Yeah, this conveys the wrong message. "--branch and --tag cannot both be
specified" would be more accurate.

Note that git clone doesn't actually "support" tags, but git clone -b
a_tag tends to do the right thing anyway

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/eric-wieser/computercraft-github/pull/11/files/0a9cc032fea14dc4adacf2e0d7a51516dbda88e9#r76338340,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA41FnctuDfo_3j-arTEwoTrNKlhxfHfks5qjho4gaJpZM4JsvBA
.

aaronmallen · 2016-08-26T02:20:11Z

ready for another CR. So now I am accounting for the -b -b situation by explicitly ignoring the index for the second -b when it's iterated over as opposed to it's value. I also did end up wrapping those keys with [] you cant have a comment as a key I also introduced new complexity for findFlag() I think we want to printError on unknown flags otherwise it'll mess with the args table and repo and dest will be wrong.

eric-wieser · 2016-08-26T03:54:57Z

I've rebased most of these into a few commits, which I've pushed to pr-11-rebased. On your pr branch, can you git reset --hard origin/pr-11-rebased && git push --force-with-lease

I'd encourage you to git commit --amend, especially if you make typos / formatting fixes

aaronmallen · 2016-08-26T04:00:22Z

done.

On Thu, Aug 25, 2016 at 10:55 PM Eric Wieser notifications@github.com
wrote:

I've rebased most of these into a few commits, which I've pushed to
pr-11-rebased. On your pr branch, can you git reset --hard
origin/pr-11-rebased && git push --force-with lease

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#11 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA41FlTiWHQxq4s1HzfVErTpsOTaySUHks5qjmOSgaJpZM4JsvBA
.

aaronmallen · 2016-08-26T05:13:15Z

tl;dr: don't merge this yet it doesn't work.

bad news on this one... the auth part of this completely doesn't work... I tested it in the browser as well and apparently user:pass@api.github.com doesn't count as an authenticated request :( I think I have a way to solve this but it'll have to wait until tomorrow. In short... don't merge this PR yet.

aaronmallen · 2016-08-26T05:23:52Z

@eric-wieser actually in the interest of resolving #8 I've removed all the auth logic for now... at least this branch provides the support structure I'll need to build that out. So go ahead and CR and merge this one as a simple resolution to #8 and I'll put in a new PR tomorrow or this weekend for the auth stuff. I've already squashed this PR down for you :)

aaronmallen · 2016-08-27T01:55:30Z

have you had a chance to CR this @eric-wieser or should I just build the support-auth with a dependency on this? Its been tested and it works.

aaronmallen · 2016-08-27T22:04:51Z

bump

eric-wieser · 2016-08-27T22:46:37Z

You can build with a dependency on this anyway - I can always rebase that PR after merging this one

aaronmallen · 2016-08-27T22:47:49Z

okie dookie... this is already squashed, and tested... literally just needs a CR and merge...

eric-wieser · 2016-08-27T22:47:56Z

programs/github

+local function findFlag(arg)
+	if arg.sub(1,1) == '-' then
+		if not acceptedFlags[arg] then
+			return printError(('Unknown flag argument %s'):format(arg))


This should print the usage too. Also, does this actually exit, or keep running anyway?

we're returning a value it should exit.

Right, but it only exits this function. The script will continue and run, won't it, treating this as the dest/repo?

Let me look into the printError() function I assumed it would terminate
the program.

On Sat, Aug 27, 2016, 21:00 Eric Wieser notifications@github.com wrote:

In programs/github
#11 (comment)
:

if not dest then

dest = treeName

treeName = 'master'
+local function findFlag(arg)

if arg.sub(1,1) == '-' then

if not acceptedFlags[arg] then

return printError(('Unknown flag argument %s'):format(arg))

Right, but it only exits this function. The script will continue and run,
won't it, treating this as the dest/repo?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/eric-wieser/computercraft-github/pull/11/files/78509095ce2a421a6e2f7dd6d245dcc050539025#r76524809,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA41FoXaVaR7Wmk1f6zugjhbdAUseYZZks5qkOvOgaJpZM4JsvBA
.

aaronmallen · 2016-10-24T04:47:54Z

@eric-wieser sorry for taking so long RL caught up to me... It still needs to go through some testing but I'd love to get some feed back on e24c416

aaronmallen · 2016-10-24T18:59:36Z

ok @eric-wieser first round of fixes is up give it a look, lets try to keep the conversation to architecture until I can run tests on it tonight :)

aaronmallen · 2016-10-24T19:00:37Z

apis/github

+	f.write(textutils.serialize(authTable))
+	f.close()
+end
+Auth.delete = function (user)


damn it why is there a space here :(

aaronmallen · 2016-10-24T19:06:45Z

I updated the PR comments to reflect the fact that we are indeed adding support for authentication in this PR after all :D

aaronmallen · 2016-10-24T19:15:59Z

readme.md

    apis      programs
    github readme.md

+#### Adding Authentication


@eric-wieser feel free to give me feedback on the verbiage here... Have you played with GH's new code review stuff? Its seems kind of cool. You can start a review instead of "Add single comment" and it will wait for you to finish commenting and submit all your comments as one message.

aaronmallen

Conversation starter and small changes needed. @eric-wieser

aaronmallen · 2016-10-24T19:18:45Z

programs/github

+
+if action == 'auth' then
+	local user, token = args[1], args[2]
+	if not user or not token then return printError("No user or token specified.") end


This should also verify the delete argument wasn't specified, so a user can simply do auth -D aaronmallen and the authentication data will be deleted without having to specify user and token.

aaronmallen · 2016-10-24T19:19:09Z

programs/github

+		print(('Github authentication for %s successfully deleted.').format(flags.delete))
+	else
+		auth.save()
+		print('Github user saved.')


@eric-wieser should we include what user was saved in this comment?

aaronmallen · 2016-10-24T19:19:39Z

programs/github

+
+if not action == 'clone' or not action == 'auth' then
+	print('Clone usage: %s').format(usage['clone']))
+  print('Auth usage: %s').format(usage['auth']))


Why am I having such a hard time with the tabs on this freaking project?

aaronmallen · 2016-10-24T19:20:24Z

apis/github

+ local authTable = Auth.getAll()
+ return authTable[user]
+end
+Auth.save = function(self)


Just to verify it is reasonable to require Auth.new in order to invoke auth.save() right?

Yeah, that's pretty fair

aaronmallen · 2016-10-24T19:21:15Z

apis/github

+	f.write(textutils.serialize(authTable))
+	f.close()
+end
+Auth.delete = function(user)


This function assumes a user was deleted even if the user doesn't exist... this shouldn't be an issue but I'm not sure how you feel about that.

eric-wieser · 2016-10-24T21:09:43Z

programs/github

+
+if not validActions[action] then
+	for k, v in pairs(validActions) do
+		print(('%s usage: %s').format(v.name, v.usage))


Terminal width is a premium here, so I'm -1 on printing anything other than the usage string

eric-wieser · 2016-10-24T21:11:15Z

readme.md

+#### Adding Authentication
+To use authenticated requests you must first [create a github](https://help.github.com/articles/creating-an-access-token-for-command-line-use/) api token on your github account.
+
+    github auth <user> <token> [-D <username>]


Should be github auth <user> [<token>| -d] in my opinion. The implementation too, obviously. Printing out the token with just the user argument would be handy too

eric-wieser · 2016-10-24T21:12:17Z

readme.md

    github readme.md

+#### Adding Authentication
+To use authenticated requests you must first [create a github](https://help.github.com/articles/creating-an-access-token-for-command-line-use/) api token on your github account.


Would be good to recommend a list of scopes here, to avoid damage (once you work out which ones are needed)

eric-wieser · 2016-10-24T21:12:20Z

readme.md

+
+The delete argument is optional and will delete specified user when defined.  The user and token arguments maybe undefined when using the delete option.
+
+**Warning:** data provided to `github auth` will be stored locally on the computercraft computer.


Worth mentioning how to revoke tokens as part of this warning.

eric-wieser · 2016-10-24T21:14:51Z

programs/github

+		if not user or not token then return printError("No user or token specified.") end
+		local auth = github.Auth('basic', user, token)
+		auth.save()
+		print(('Github user %s successfully saved.').format(auth.user))


"Successfully saved github token for user %s" is a better message IMO

eric-wieser · 2016-10-24T21:15:37Z

programs/github

-	-- parse input
-	local repo, treeName, dest = select(2, ...)
+-- get flag arguments
+local acceptedCloneFlags = {


Can't this be folded into validActions?

eric-wieser · 2016-10-24T21:15:58Z

programs/github

+	['--delete'] = 'delete'
+}
+
+local function getFlagTable()


Which would make this just be actions[action].flags

eric-wieser · 2016-10-24T23:01:20Z

programs/github

+			['--tag'] = 'tag',
+			['-a'] = 'authed',
+			['-auth'] = 'authed'
+		}


Screwy indentation strikes again! (two spaces for clone, yet tabs here)

eric-wieser · 2016-10-24T23:03:05Z

programs/github

@@ -134,24 +128,26 @@ if action == 'clone' then
 end

 if action == 'auth' then


nitpick: add action = validActions[action] up where actions is defined, then compare against validActions.auth. Then nothing else needs to know about the validActions table, and getFlagTable() becomes pointless

eric-wieser · 2016-10-24T23:03:41Z

readme.md

+To use authenticated requests you must first [create a github](https://help.github.com/articles/creating-an-access-token-for-command-line-use/) api token on your github account. You do not need to provide any api scopes for the token unless you plan on accessing private repositories.

-    github auth <user> <token> [-D <username>]
+    github auth <user> [<api token> | -D]


I'd argue lowercase d because 1) it's easier to type, 2), git branch -d <name> is a thing

eric-wieser · 2016-10-24T23:04:32Z

readme.md

 The delete argument is optional and will delete specified user when defined.  The user and token arguments maybe undefined when using the delete option.

-**Warning:** data provided to `github auth` will be stored locally on the computercraft computer.
+**Warning:** data provided to `github auth` will be stored locally on the computercraft computer. You can delete the access token at anytime by hitting the delete button in your personal access tokens screen on github.


Can you link to that page? https://github.com/settings/tokens, right?

eric-wieser · 2016-10-24T23:05:06Z

programs/github

-		github.Auth.delete(flags.delete)
-		print(('Github authentication for %s successfully deleted.').format(flags.delete))
+		github.Auth.delete(user)
+		print(('Successfully deleted github token for user %s'):format(flags.delete))


Actually, we can probably cut the world "Successfully` (here and below), given our terminals are narrow

eric-wieser · 2016-10-24T23:06:04Z

programs/github

@@ -1,15 +1,28 @@
 local github = dofile("apis/github")
+local passed = {...}


Not sure how this slipped through the last one

whats wrong with this line?

Oh, I see what's wrong - it's repeated further down! (line 62?)

yeah derp... had to move it to top of file to avoid stupid vararg function error.

reload the latest PR

eric-wieser · 2016-10-24T23:13:31Z

programs/github


-local usage = "Usage: github clone <user>/<repo> [<branch>|<tag>] [<destination>]"
+local validActions = {
+  clone = {


This line isn't a tab!

aaronmallen · 2016-10-24T23:17:45Z

check out the latest... gotta break for a few hours, will continue testing later tonight.

eric-wieser

Looks pretty good other than the whitespace breakage

eric-wieser · 2016-10-24T23:19:07Z

programs/github

-  },
-  auth  = {
+	},
+	auth	= {


eric-wieser · 2016-10-24T23:19:58Z

programs/github

@@ -1,10 +1,10 @@
 local github = dofile("apis/github")
 local passed = {...}


Maybe this should be {select(2, ...)}, so as to automatically skip selectAction, which lets you remove the suspect condition I comment on below

eric-wieser · 2016-10-24T23:21:04Z

programs/github

-
 local function findFlag(arg)
-	local acceptedFlags = getFlagTable()
+	local acceptedFlags = action.flags


action.flags is shorter than acceptedFlags ;)

eric-wieser · 2016-10-24T23:22:17Z

programs/github

 end

-if action == 'clone' then
+if action.name == 'Clone' then


I'd argue if action == validActions.clone is better (and that validActions is better named subcommands)

eric-wieser · 2016-10-24T23:22:39Z

programs/github

 			size = size + item.size
 			term.clearLine()
-			print("  "..item:fullPath())
+			print("	"..item:fullPath())


Finding and replacing space pairs with tabs was not the right solution

eric-wieser · 2016-10-24T23:23:07Z

programs/github

-else
-	print(validActions[action].usage)
-end
+print(action.usage)


Does this handle the case where we fail to find a valid action? Or is that handled above?

This is handled above now... We shouldn't get here unless action is defined and valid, but missused for some reason.

eric-wieser · 2016-10-24T23:24:32Z

apis/github

+end
+Auth.get = function(user)
+ local authTable = Auth.getAll()
+ return authTable[user]


spaces here should be tabs

eric-wieser · 2016-10-24T23:25:34Z

readme.md

 -----

-    github clone <user>/<repo> [<branch>|<tag>] [<destination>]
+#### Cloning a repo


Should be three not four hash signs

aaronmallen · 2016-10-25T02:39:01Z

@eric-wieser tested, rebased, and ready for deep code-review

aaronmallen

@eric-wieser I did a little CR of my own but will wait for yours before pushing these changes.

aaronmallen · 2016-10-25T02:42:39Z

readme.md

+
+    github auth <user> [<api token> | -d]
+
+The delete argument is optional and will delete specified user when defined.  The user and token arguments maybe undefined when using the delete option.


Damnit @eric-wieser this will need to be changed to

The api token argument maybe undefined when using the delete option.

I'd argue that all of these words are fully described by the [ a | b ] notation which means "a, b, or nothing at all"

aaronmallen · 2016-10-25T02:44:29Z

programs/github

-local usage = "Usage: github clone <user>/<repo> [<branch>|<tag>] [<destination>]"
+local subcommands = {
+	clone = {
+		name = 'Clone',


hrm the name property on these tables isn't really needed anymore, should I kill it?

Yep, I think kill it

aaronmallen · 2016-10-25T02:45:32Z

programs/github

+local action = subcommands[selectedAction]
+if not action then
+	for k, v in pairs(subcommands) do
+		print(v.usage)


I wonder if a line break would be appropriate here as well?

Depends if they wrap on the default console (how wide is it?)

It wraps....

Perhaps manually wrapping the usage strings neatly is the right thing to do then? Unless CC screens can be different sizes. Either way, that's a job for another PR.

aaronmallen · 2016-10-25T02:48:28Z

programs/github

+
+	if flags.authed and not auth then
+		printError('Unknown User!')
+		print(subcommands['auth'].usage)


Is printing usage necessary here? we're returning the printError on all other cases like this.

Oh I see this case IS slightly different then other instances of us returning printError, in this particular case we are expecting the user to utilize a separate subcommand, and showing the user how to utilize that subcommand. The question is still semi valid though, should we print usage for the auth subcommand here or just return the printError?

How about Unknown user! Add one with 'git auth'

aaronmallen · 2016-10-25T03:01:15Z

A small caveat to this change: with an authorized request it is now possible to download a repo that exceeds the allowed amount of space on the computercraft computer. Computercraft actually already handles this pretty well IMO. It'll stop the download and throw a printError letting the user know they're out of space. I think this is a fine way of handling this, I just wanted you to be aware of the limitation.

eric-wieser · 2016-10-25T13:39:31Z

apis/github


+-- A class for authorization
+local authFile = '.github-auth'
+local function writeAuth(data)


Don't see why this should be a free function. Why not just leave it in Auth.save?

DRY... I was calling the same logic in save and delete.

Oops, missed that it was in delete as well. Sure, this is reasonable.

eric-wieser · 2016-10-25T13:43:07Z

A small caveat to this change: with an authorized request it is now possible to download a repo that exceeds the allowed amount of space on the computercraft computer.

That's not your problem in this pull request, but thanks for the heads up! Perhaps the command should forecast its size before continuing (in another PR). Is there an api to get remaining space in computercraft?

eric-wieser · 2016-10-25T13:43:52Z

Two final things:

Does this rebased version still work?
What happens if an invalid token is provided?

aaronmallen · 2016-10-25T15:33:48Z

Two final things:

Does this rebased version still work?
What happens if an invalid token is provided?

Yes this rebase version works
I don't know let me test that this evening.

aaronmallen · 2016-10-25T15:37:54Z

That's not your problem in this pull request, but thanks for the heads up! Perhaps the command should forecast its size before continuing (in another PR). Is there an api to get remaining space in computercraft?

I agree it's beyond the scope of this PR but it is a limitation we should be aware of. I think there is in the FS API, specifically this method, however I'm not sure what the "size" property is in the github api (is it bytes as well?)

added support for authorized request updated readme

aaronmallen · 2016-10-25T19:28:41Z

@eric-wieser so heres what I discovered during my testing... My testing was invalid in the first place :( This was never actually counting as an authenticated request. Take a gander at the latest commit to see how I've fixed that :D

Basically I was attempting to clone twbs/bootstrap because it has a large tree so it hits a whole bunch of api endpoints. Unfortunately you run out of space before the amount of endpoints I needed to hit to revoke my ability to make unauthorized requests happens.

To answer this question:

What happens if an invalid token is provided?

After finally hitting my daily limit of unauthorized API requests I tried making a request to clone twbs/bootstrap with user: eric-wieser, token: foobarbaz and what happens is this:

github:16: Could not get github API from repos/twbs/bootstrap/git/trees/master

When I try a request to clone twbs/bootstrap with user: aaronmallen, token: my_valid_token it downloads as expected :D

I would argue that checking the token is valid would not be within scope of this PR, but I intend to open up a new PR to resolve both this issue AND checking size before downloading :D

eric-wieser · 2016-10-25T19:52:40Z

I would argue that checking the token is valid would not be within scope of this PR

This PR should fail gracefully if the token is wrong, and the request is rejected. If it's not possible to tell the difference between "this worked because I am under the limit", and "this worked because I am authenticated, then sure, leave that for another time

eric-wieser reviewed Aug 25, 2016
View reviewed changes

eric-wieser mentioned this pull request Aug 25, 2016

added simple installation #4

Closed

aaronmallen reviewed Aug 25, 2016
View reviewed changes

aaronmallen changed the title ~~add support for authorized api access~~ Change branch syntax to match real git command. Aug 26, 2016

eric-wieser reviewed Aug 27, 2016
View reviewed changes

aaronmallen mentioned this pull request Aug 27, 2016

Separate downloading and installation #12

Open

aaronmallen commented Oct 24, 2016

View reviewed changes

aaronmallen changed the title ~~Change branch syntax to match real git command.~~ Support Auth Oct 24, 2016

aaronmallen commented Oct 24, 2016

View reviewed changes

eric-wieser suggested changes Oct 24, 2016

View reviewed changes

eric-wieser reviewed Oct 24, 2016

View reviewed changes

eric-wieser suggested changes Oct 24, 2016

View reviewed changes

eric-wieser reviewed Oct 24, 2016

View reviewed changes

aaronmallen commented Oct 25, 2016

View reviewed changes

eric-wieser reviewed Oct 25, 2016

View reviewed changes

aaronmallen added 2 commits October 25, 2016 13:57

Change branch syntax to match real git command

7d80aa8

added support for authorized request updated readme

removed support for basic authentication and added oauth support

235781a

eric-wieser approved these changes Oct 25, 2016

View reviewed changes

eric-wieser merged commit e96dd54 into eric-wieser:master Oct 25, 2016


		The delete argument is optional and will delete specified user when defined. The user and token arguments maybe undefined when using the delete option.

		Warning: data provided to `github auth` will be stored locally on the computercraft computer.

		@@ -134,24 +128,26 @@ if action == 'clone' then
		end

		if action == 'auth' then

		@@ -1,15 +1,28 @@
		local github = dofile("apis/github")
		local passed = {...}

		@@ -1,10 +1,10 @@
		local github = dofile("apis/github")
		local passed = {...}


		github auth <user> [<api token> \| -d]

		The delete argument is optional and will delete specified user when defined. The user and token arguments maybe undefined when using the delete option.

Support Auth #11

Support Auth #11

Uh oh!

Conversation

aaronmallen commented Aug 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixed

Added

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eric-wieser commented Aug 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronmallen commented Aug 25, 2016

Uh oh!

aaronmallen commented Aug 25, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eric-wieser commented Aug 25, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaronmallen commented Aug 25, 2016

Uh oh!

aaronmallen commented Aug 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaronmallen commented Aug 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eric-wieser commented Aug 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronmallen commented Aug 26, 2016

Uh oh!

aaronmallen commented Aug 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronmallen commented Aug 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronmallen commented Aug 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronmallen commented Aug 27, 2016

Uh oh!

eric-wieser commented Aug 27, 2016

Uh oh!

aaronmallen commented Aug 27, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaronmallen commented Oct 24, 2016

Uh oh!

aaronmallen commented Oct 24, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaronmallen commented Oct 24, 2016

Uh oh!

aaronmallen Oct 24, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aaronmallen left a comment

Choose a reason for hiding this comment

aaronmallen commented Aug 25, 2016 •

edited

Loading

eric-wieser commented Aug 25, 2016 •

edited

Loading

aaronmallen commented Aug 25, 2016 •

edited

Loading

aaronmallen commented Aug 26, 2016 •

edited

Loading

eric-wieser commented Aug 26, 2016 •

edited

Loading

aaronmallen commented Aug 26, 2016 •

edited

Loading

aaronmallen commented Aug 26, 2016 •

edited

Loading

aaronmallen commented Aug 27, 2016 •

edited

Loading

aaronmallen Oct 24, 2016 •

edited

Loading