Skip to content

change farmer_pk and pool_pk to type str#118

Merged
altendky merged 1 commit into
ericaltendorf:developmentfrom
cciollaro:patch-1
Apr 17, 2021
Merged

change farmer_pk and pool_pk to type str#118
altendky merged 1 commit into
ericaltendorf:developmentfrom
cciollaro:patch-1

Conversation

@cciollaro

Copy link
Copy Markdown
Contributor

currently when supplying these values you get the following exception:

marshmallow.exceptions.ValidationError: {'plotting': {'farmer_pk': ['Not a valid integer.'], 'pool_pk': ['Not a valid integer.']}}

change farmer_pk and pool_pk to type str

@altendky altendky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like these should maybe be something more specific so they can't be strings like 'the blue & green 37s are *$*#&', but str is still better than int. Thanks for the fix @cciollaro.

@altendky altendky merged commit bf31c40 into ericaltendorf:development Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants