Development#47
Merged
Merged
Conversation
ericaltendorf
requested changes
Mar 26, 2021
ericaltendorf
left a comment
ericaltendorf
left a comment
Owner
There was a problem hiding this comment.
Thanks so much for this, much cleaner than I was fearing it would end up being. Just one request.
ericaltendorf
approved these changes
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow a different number of plots per tmp dir.
This sets up a pattern of overriding certain parameters per tmp file. In this case, the max number of jobs per tmp file defaults to the scheduler config 'tmpdir_max_jobs', but allows each tmp dir to override with it's own unique value for max jobs. This same pattern could be used to specialize other attributes per tmp dir.
The main use for this is for handling heterogeneous sizes of tmp drives with a single plotman configuration. For example, this would make it easy to support both 1TB, 2TB, and 6.4TB tmp dirs in the same configuration while fully utilizing the available space of each.