Fix model namespace normalization for locally packaged models#42
Draft
Copilot wants to merge 3 commits into
Draft
Fix model namespace normalization for locally packaged models#42Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Co-authored-by: ericcurtin <1694275+ericcurtin@users.noreply.github.com>
Co-authored-by: ericcurtin <1694275+ericcurtin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix bug related to running locally loaded model
Fix model namespace normalization for locally packaged models
Oct 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When users packaged a local GGUF model without specifying a namespace, the model could not be run afterward. This occurred because the model name was not normalized during packaging, causing a mismatch between the stored name and the name used during lookup.
For example:
The root cause was that:
packagecommand stored the model without normalizing the name (e.g., asmy-model)runcommand normalizedmy-modeltoai/my-model:latestbefore lookupai/my-model:latestdidn't match the stored nameSolution
This PR ensures that model names are normalized to include the default
ai/namespace before being stored, making the behavior consistent across all operations. Nowmy-modelbecomesai/my-model:latestduring packaging, which matches what all other commands expect.Changes
newModelRunnerTarget()tagModel()Result
The workflow now works seamlessly:
This ensures that
ai/is the default namespace in all cases, as intended by the original design.Fixes issue where locally packaged models without explicit namespaces could not be run.
Original prompt
Fixes docker#250
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.