Skip to content

Bump nltk from 3.8.1 to 3.9 in /trip_planner#2

Open
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/pip/trip_planner/nltk-3.9
Open

Bump nltk from 3.8.1 to 3.9 in /trip_planner#2
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/pip/trip_planner/nltk-3.9

Conversation

@dependabot
Copy link
Copy Markdown

@dependabot dependabot Bot commented on behalf of github Feb 6, 2025

Bumps nltk from 3.8.1 to 3.9.

Changelog

Sourced from nltk's changelog.

Version 3.9.1 2024-08-19

  • Fixed bug that prevented wordnet from loading

Version 3.9 2024-08-18

  • Fix security vulnerability CVE-2024-39705 (breaking change)
  • Replace pickled models (punkt, chunker, taggers) by new pickle-free "_tab" packages
  • No longer sort Wordnet synsets and relations (sort in calling function when required)
  • Only strip the last suffix in Wordnet Morphy, thus restricting synsets() results
  • Add Python 3.12 support
  • Many other minor fixes

Thanks to the following contributors to 3.8.2: Tom Aarsen, Cat Lee Ball, Veralara Bernhard, Carlos Brandt, Konstantin Chernyshev, Michael Higgins, Eric Kafe, Vivek Kalyan, David Lukes, Rob Malouf, purificant, Alex Rudnick, Liling Tan, Akihiro Yamazaki.

Version 3.8.1 2023-01-02

  • Resolve RCE vulnerability in localhost WordNet Browser (#3100)
  • Remove unused tool scripts (#3099)
  • Resolve XSS vulnerability in localhost WordNet Browser (#3096)
  • Add Python 3.11 support (#3090)

Thanks to the following contributors to 3.8.1: Francis Bond, John Vandenberg, Tom Aarsen

Version 3.8 2022-12-12

  • Refactor dispersion plot (#3082)
  • Provide type hints for LazyCorpusLoader variables (#3081)
  • Throw warning when LanguageModel is initialized with incorrect vocabulary (#3080)
  • Fix WordNet's all_synsets() function (#3078)
  • Resolve TreebankWordDetokenizer inconsistency with end-of-string contractions (#3070)
  • Support both iso639-3 codes and BCP-47 language tags (#3060)
  • Avoid DeprecationWarning in Regexp tokenizer (#3055)
  • Fix many doctests, add doctests to CI (#3054, #3050, #3048)
  • Fix bool field not being read in VerbNet (#3044)
  • Greatly improve time efficiency of SyllableTokenizer when tokenizing numbers (#3042)
  • Fix encodings of Polish udhr corpus reader (#3038)
  • Allow TweetTokenizer to tokenize emoji flag sequences (#3034)
  • Prevent LazyModule from increasing the size of nltk.dict (#3033)
  • Fix CoreNLPServer non-default port issue (#3031)
  • Add "acion" suffix to the Spanish SnowballStemmer (#3030)
  • Allow loading WordNet without OMW (#3026)
  • Use input() in nltk.chat.chatbot() for Jupyter support (#3022)
  • Fix edit_distance_align() in distance.py (#3017)
  • Tackle performance and accuracy regression of sentence tokenizer since NLTK 3.6.6 (#3014)
  • Add the Iota operator to semantic logic (#3010)
  • Resolve critical errors in WordNet app (#3008)
  • Resolve critical error in CHILDES Corpus (#2998)
  • Make WordNet information_content() accept adjective satellites (#2995)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [nltk](https://github.com/nltk/nltk) from 3.8.1 to 3.9.
- [Changelog](https://github.com/nltk/nltk/blob/develop/ChangeLog)
- [Commits](nltk/nltk@3.8.1...3.9)

---
updated-dependencies:
- dependency-name: nltk
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added the dependencies Pull requests that update a dependency file label Feb 6, 2025
@blackboxaiapp
Copy link
Copy Markdown

blackboxaiapp Bot commented Feb 6, 2025

PR Review: Update NLTK from 3.8.1 to 3.9

Critical Issues

  1. Python Version Requirement Change:

    • NLTK 3.9 now requires Python 3.8+, an increase from 3.7+ in version 3.8.1. This could break compatibility if the project uses Python 3.7.
    • Action: Verify that the project's minimum Python version is 3.8 or higher. Update.
  2. Breaking Changes in WordNet:

    • The changelog notes a modification: "Only strip the last suffix in Wordnet Morphy, thus restricting synsets() results". This affects any code that relies on WordNet's synsets() function.
    • Action: Review and test any code using WordNet's synsets() to ensure it functions as expected with the new behavior.
  3. Security Vulnerability Fix:

    • The update includes a fix for security vulnerability CVE-2024-39705, which is marked as breaking change.
    • Action: Review the security fix details and conduct thorough testing to ensure there is no negative impact on existing functionality.

Suggestions

  1. Pickle-free Models:

    • NLTK 3.9 replaces pickled models with new pickle-free "_tab" packages, requiring adjustments in how models are loaded or used.
    • Suggestion: Review any code that loads NLTK models to ensure compatibility with the new format.
  2. Performance Optimization:

    • The changelog indicates that WordNet synsets and relations will no longer be sorted, potentially enhancing performance.
    • Suggestion: Consider reviewing and optimizing code that interacts with WordNet synsets and relations to benefit from this change.
  3. Python 3.12 Support:

    • NLTK 3.9 adds support for Python 3.
    • Suggestion: If not previously tested, consider testing the project with Python 3.12 to leverage improvements and ensure compatibility.

Summary

The update to NLTK 3.9 introduces significant security fixes, performance improvements, and features, but it also includes breaking changes that must be addressed:

  1. Critical Requirement: Update project to ensure minimum Python version is 3.8+.
  2. Comprehensive Testing: Conduct thorough tests on WordNet functionality, particularly with synsets().
  3. Careful Review and Testing: Scrutinize the impact of the security fix (CVE-2024-39705).

Post-Merge Recommendations:

  1. Update any model loading code to accommodate the new pickle-free format.
  2. Explore potential performance optimizations related to WordNet operations.
  3. Test with Python 3.12 if not already completed.

Proper execution of these steps will ensure a smooth transition to NLTK 3.9 while maintaining codebase stability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants