[pull] develop from rainbow-me:develop#360
Merged
Merged
Conversation
Our image-signing pipeline has a fast-path that, in theory, sends some token-icon URLs straight to Cloudinary for resizing instead of routing them through Imgix. While reading through this code recently it became clear the path hasn't actually been firing in production for years. Its URL predicate was narrowed in #4774 (Apr 2023) as a side change to an unrelated ENS marquee feature, and the new shape it looked for has never matched any URL our backends produce. Org-wide code search across all 17 `rainbow-me` repos that mention `rainbowme-res` finds the matching URL form in exactly one place: the predicate itself. Imgix has been silently carrying every icon since. Cloudinary's delivery reports back this up. The unique transformation signature this fast-path produces accounts for roughly 770KB of traffic across our `rainbowme` account over the last 30 days, against 91GB of total bandwidth, and the dimensions match what we'd expect from very old client builds still running the pre-narrowing predicate. None of that traffic comes from current builds. This change deletes the dead handler and its branch in the Imgix path. Behavior is unchanged for any URL we currently produce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )