[pull] develop from rainbow-me:develop#362
Merged
Merged
Conversation
## Description This PR refactors Send sheet, so sponsored-send feature work in the upcoming PR can stay focused on the behavior change and not refactoring. Observable behavior unchanged. The goal here is to move the existing Send screen into the feature module and make the major pieces easier to review before adding sponsorship-specific behavior.
* fix: android prediction card layout collapse * feat: update Discover tab icon * fix: Perps positions screen padding scroll Kane's fix: replace the scroll view’s iOS-only `contentInset`-based bottom spacing with `paddingBottom` on both platforms, because in the affected perps flow the scroll container was rendering content but not correctly respecting the footer/bottom inset during that mount path, which made the view appear scrollable and then snap back as if the effective viewport ended above the actual footer; he verified that switching to `paddingBottom` resolved the issue without meaningful downside in this case, noting that `contentInset` is normally nicer on iOS because it also handles the scroll indicator inset and affects layout more natively, but here the cross-platform `paddingBottom` approach was the reliable fix for what he suspected was a React Native inset-handling bug. Co-Authored-By: Kane Thomas <kanethomas1997@gmail.com> --------- Co-authored-by: Kane Thomas <kanethomas1997@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )