Fix building under current Rust master (std::vec dep).#5
Open
tekacs wants to merge 2 commits intoerickt:masterfrom
Open
Fix building under current Rust master (std::vec dep).#5tekacs wants to merge 2 commits intoerickt:masterfrom
tekacs wants to merge 2 commits intoerickt:masterfrom
Conversation
Hopefully a viable approach?
Author
|
... aaand the tests also needed re-writing. Fixing. |
Author
|
And now the last fix I have to leave to someone who knows what they're doing in this context, whilst I go and bring my Rust knowledge up to the current language version. :) Presumably the trait for as_slice (via std::str::Str) needs to be brought into the current scope without overlapping with super::Str. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are just:
use std::vec;
...
Vec -> vec::Vec
Do switch this out if there's a tidier way of doing this that I've ignored. The persistent overlap between Vec/Vec is the source of the verbosity.