Colors#41
Conversation
| // #335280 is the new blue by Canonical | ||
| // https://github.com/CanonicalLtd/desktop-design/blob/master/Colour/colour.png | ||
| property string themableBlue: Theme.name == "Ubuntu.Components.Themes.SuruDark" ? UbuntuColors.blue : "#335280" | ||
| property string linkColor: " style=\"color:"+about_column.themableBlue+";\"" //' style="color:'+ about_column.themableBlue +';"' |
There was a problem hiding this comment.
The linkColor property is handy and should be still used in every html string later in the code because it encapsulate the color into the html style attribute, but it needs to point to theme.palette.normal.activity instead, like you pointed out. Maybe you just overlooked this 😅 but thanks for the PR, this color was not part of the theme palette yet when has been introduced here
There was a problem hiding this comment.
Haha, yes, you are right. I was too much in "cleaning mode". Of course keeping the property and set the color once is much better. I will fix that.
| textFormat: Text.RichText | ||
| font.underline: false | ||
| text: i18n.tr("Released under the terms of the GNU GPL v3.<br>Source code available on") + " <a style=\"text-decoration: none;color:"+about_column.themableBlue+";\" href=\"https://github.com/ernesst/ActivityTracker\">GitHub.com</a>" | ||
| text: i18n.tr("Released under the terms of the GNU GPL v3.<br>Source code available on") + " <a "+about_column.linkColor+" style=\"text-decoration: none;\" href=\"https://github.com/ernesst/ActivityTracker\">GitHub.com</a>" |
There was a problem hiding this comment.
Sorry if I'm nitpicking this too much, but is it fine to put the style attribute twice here? Did you tested it and it works?
There was a problem hiding this comment.
- I did not add this, that is from the original code
- just tried it, seems to work, results in the github link not having a underline
- Since all the other links do have an underline, lets remove it here too to have a consistent layout
There was a problem hiding this comment.
- The original code had the
styleattribute only once in that line and had thecolorproperty explicit and just the color appended viaabout_column.themableBluevariable, while you usedabout_column.linkColorwhich brings in the full html style attribute with color property set. - 👍🏻
- Oh, ok not sure why I did this, let's make it consistent.
Anyway, this LGTM
2 participants
Replace some hardcoded colors with system colors in about page