perf: optimize directory cache and animation initialization - #22
Open
VanCZ1 wants to merge 1 commit into
Open
Conversation
Author
|
OpenAnimationReplacer_3.2.0.log |
Author
|
This check is failed because github now blocks checking out fork pr code in pull_request_target workflows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimized the logic of directory cache and animation initialization, significantly reducing loading time.
Core Changes
Directory cache
Remove the unused
CachedModDirectory::entries.Add
PrecacheAnimationHash()to replacePrecacheAnimationHashes(), avoiding repeated traversal.Add
regularAnimationFilesinCacheAnimationFilesInDirectory(), avoiding repeated traversal.Directory parsing
Capture cached
CachedModDirectoryandCachedLegacySubModnodes by pointer, avoiding deep copying. Keep the shared lock ong_directoryCache.cacheLockheld until theworkerPoolhas finished.Animation initialization
Add
_animationPathToIndexMapto replace repeated linear scans inReplacerProjectData::TryAddAnimationToAnimationBundleNames().Call
SubMod::AddReplacerProject()andSubMod::SortReplacementAnimationsByPath()insubModsToUpdaterather than after every insertion.Call
SubMod::InitializeReplacementAnimation()for every insertion, avoiding repeated traversal insubModsToUpdate, and useUtils::ComparePaths()to keep the path-matching behavior ofSubMod::LoadReplacementAnimationDatas().Testing