Skip to content

fix(bldc_driver): fix driver level inversion#100

Merged
finger563 merged 5 commits intomainfrom
bugfix/97-bldc-driver-level-inversion
Aug 1, 2023
Merged

fix(bldc_driver): fix driver level inversion#100
finger563 merged 5 commits intomainfrom
bugfix/97-bldc-driver-level-inversion

Conversation

@finger563
Copy link
Copy Markdown
Contributor

@finger563 finger563 commented Aug 1, 2023

Description

  • Update to set output to low when counting up, and high when counting down. This means that setting a value of 25% will actually have the output high for 25% of the time.
  • Update examples to always calibrate by setting zero electrical offset to 0.
  • Update bldc motor example to 1) always calibrate sensor direction, 2) always calibrate electrical angle, and 3) enable the motor so it actually runs
  • Update bldc driver to configure the compare actions for the low side generators
  • Check error of tiemr functions to not enable if they fail (since it wont work anyway). Havent seen those errors, but just in queso.
  • Update example to always calibrate sensor direction (since its a test)
  • Updated example to debug log since its a test

Motivation and Context

Fixes #97

⚠️ You will have to recalibrate your motors after upgrading to this code ⚠️

How has this been tested?

Building and running the bldc motor and bldc haptics examples.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

BLDC Motor example:
image1
iamge2

BLDC Haptics example:
image3

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

* Update to set output to low when counting up, and high when counting down. This means that setting a value of 25% will actually have the output high for 25% of the time.
Fixes #97
* Update examples to always calibrate by setting zero electrical offset to 0.
@finger563 finger563 added bug Something isn't working motor control bldc Related to Brushless DC Motors labels Aug 1, 2023
* Update bldc motor example to 1) always calibrate sensor direction, 2) always calibrate electrical angle, and 3) enable the motor so it actually runs
* Update bldc driver to configure the compare actions for the low side generators
* Check error of tiemr functions to not enable if they fail (since it wont work anyway). Havent seen those errors, but just in queso.
* Update example to always calibrate sensor direction (since its a test)
* Updated example to debug log since its a test
@finger563 finger563 merged commit 4b814f0 into main Aug 1, 2023
@finger563 finger563 deleted the bugfix/97-bldc-driver-level-inversion branch August 1, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bldc Related to Brushless DC Motors bug Something isn't working motor control

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BLDC Driver issue

1 participant