[packaging] Exclude also the submodules of test and docs (ESPTOOL-927)#1012
[packaging] Exclude also the submodules of test and docs (ESPTOOL-927)#1012espressif-bot merged 1 commit intoespressif:masterfrom
Conversation
👋 Hello befeleme, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. Click to see more instructions ...
Review and merge process you can expect ...
|
|
Also, please see the bot response above and change your commit message accordingly. |
900f705 to
16cdbea
Compare
- "test" - installed unwanted "test/efuse_scripts/*py" - "docs" - installed unwanted "docs/en/conf.py" - "ci" - added "*" to be future-proof - "flasher_stub" no longer exists
16cdbea to
908d0b5
Compare
When running the wheel build of esptool 4.8.0 in Fedora, the
docs/en/conf.pyandtest/efuse_scripts/*.pywere included in the distribution.Apparently, setuptools excludes only the first level of modules, unless specified otherwise. Following the official documentation, the
Importantpart, adding asterisks to exclude all the found submodules does the trickhttps://setuptools.pypa.io/en/latest/userguide/package_discovery.html#finding-simple-packages
I've tested it during the Fedora RPM build and verified this change works for us.