Skip to content

fix update site issues with the org.commonmark#1112

Closed
kolipakakondal wants to merge 2 commits into
masterfrom
jna_builds_update
Closed

fix update site issues with the org.commonmark#1112
kolipakakondal wants to merge 2 commits into
masterfrom
jna_builds_update

Conversation

@kolipakakondal

@kolipakakondal kolipakakondal commented Jan 11, 2025

Copy link
Copy Markdown
Collaborator

Description

Please include a summary of the change and which issue is fixed.

Fixes # (IEP-XXX)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • ESP-IDF Version:
  • OS (Windows,Linux and macOS):

Dependent components impacted by this PR:

  • Component 1
  • Component 2

Checklist

  • PR Self Reviewed
  • Applied Code formatting
  • Added Documentation
  • Added Unit Test
  • Verified on all platforms - Windows,Linux and macOS

Summary by CodeRabbit

  • New Features

    • Updated Eclipse and repository locations to newer versions (4.33 and 2024-09)
    • Added support for new Eclipse tools and language features
  • Dependency Updates

    • Updated LSP4E and TM4E plugin versions
    • Replaced outdated JNA and XML-related units with newer versions
  • Refactor

    • Removed legacy bundles and units
    • Streamlined feature and bundle configurations

@coderabbitai

coderabbitai Bot commented Jan 11, 2025

Copy link
Copy Markdown

Walkthrough

This pull request focuses on updating the Eclipse target platform configuration for the Espressif IDF (Integrated Development Framework) project. The changes primarily involve updating repository URLs to newer versions, removing outdated units, and adding new units. The modifications span two key files: the target configuration file and the category XML file. The updates include upgrading Eclipse update sites, adding new features like TM4E (Text Mate), and refreshing the list of included bundles and dependencies.

Changes

File Change Summary
releng/com.espressif.idf.target/com.espressif.idf.target.target - Updated Eclipse updates URL from 4.32 to 4.33
- Updated release repository to 2024-09
- Removed multiple outdated units (e.g., XML bind, activation)
- Added new units like com.sun.jna, org.apache.batik.*
- Updated LSP4E and TM4E repository versions
releng/com.espressif.idf.update/category.xml - Added org.eclipse.tm4e.feature
- Removed bundles: org.eclipse.tm4e.languageconfiguration, org.eclipse.tm4e.ui, org.eclipse.tm4e.core
- Removed Mylyn WikiText bundles

Possibly related PRs

Suggested Reviewers

  • AndreiFilippov
  • sigmaaa

Poem

🐰 Hopping through Eclipse's grove,
Updating units with a loving shove,
Repositories bloom, versions take flight,
Target configs dancing with delight!
A rabbit's release, precise and neat 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32486bb and fa7c513.

📒 Files selected for processing (2)
  • releng/com.espressif.idf.target/com.espressif.idf.target.target (5 hunks)
  • releng/com.espressif.idf.update/category.xml (1 hunks)
🔇 Additional comments (6)
releng/com.espressif.idf.target/com.espressif.idf.target.target (5)

43-46: Document the necessity of Apache Batik dependencies

The addition of Apache Batik dependencies (css, util, i18n, constants) suggests new SVG handling capabilities:

  1. Please document why these dependencies are needed
  2. Consider specifying explicit versions instead of "0.0.0"

85-89: LGTM: LSP4E/LSP4J updates look good

The update to LSP4E 0.26.5 and addition of LSP4J dependencies will improve language server support. This is a minor version update that should be backward compatible.


92-94: Verify TM4E version compatibility

The significant version jump in TM4E (0.9.0 → 0.13.0) requires careful testing:

  1. Ensure existing TextMate grammar configurations still work
  2. Test the new language pack feature across platforms

6-6: Verify Eclipse platform version compatibility

The update to Eclipse 4.33 and 2024-09 releases represents a significant version change. While these updates are good for maintaining current dependencies:

  1. Ensure thorough testing on all supported platforms (Windows, Linux, macOS) as mentioned in the PR description
  2. Verify backward compatibility with existing workspaces

Also applies to: 22-22


41-42: Specify explicit JNA version instead of using "0.0.0"

Given that this PR specifically focuses on JNA builds update, using "0.0.0" (latest version) for JNA dependencies could lead to inconsistent builds. Consider:

  1. Specifying explicit versions for better reproducibility
  2. Documenting the minimum required JNA version
releng/com.espressif.idf.update/category.xml (1)

30-32: LGTM: Improved TM4E integration

The switch from individual TM4E bundles to using the feature-based inclusion is a better approach:

  1. Simplifies dependency management
  2. Ensures consistent versioning of related bundles

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kolipakakondal kolipakakondal changed the title Jna builds update fix update site issues with the org.commonmark Jan 11, 2025
@kolipakakondal kolipakakondal deleted the jna_builds_update branch January 11, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant