Iep 1647 upd#1334
Conversation
9f45eea to
41fad3a
Compare
|
Caution Review failedThe pull request is closed. WalkthroughRefines the Windows CI release workflow: quotes the keytool alias argument, captures full keytool output as text, validates presence of PrivateKeyEntry by parsing that text, and prints the captured output on failures before throwing. Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub as GitHub Actions
participant PowerShell as Windows runner (PowerShell)
participant Keytool as keytool
Note over PowerShell,Keytool #DDEEFF: Windows verification step
GitHub->>PowerShell: run signing verification step
PowerShell->>Keytool: invoke keytool -list -keystore ... "-alias \"$env:ALIAS\""
Keytool-->>PowerShell: command stdout/stderr (captured)
alt exit code == 0 and outText contains "PrivateKeyEntry"
PowerShell->>GitHub: mark verification success
else any failure or no PrivateKeyEntry
PowerShell->>GitHub: write full captured output to host
PowerShell->>GitHub: throw error / fail step
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ci fix for ps regex
Summary by CodeRabbit